From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7C46E2405D for ; Mon, 7 May 2018 04:26:55 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VIYe7MBDv-EC for ; Mon, 7 May 2018 04:26:55 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BB4612405B for ; Mon, 7 May 2018 04:26:54 -0400 (EDT) Date: Mon, 7 May 2018 11:27:05 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v3] Fix warnings Message-ID: <20180507082704.5iqu7zsu4c72ya5j@tkn_work_nb> References: <1524822818-22641-1-git-send-email-gleb-skiba@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1524822818-22641-1-git-send-email-gleb-skiba@mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Gleb Skiba Cc: kyukhin@tarantool.org, tarantool-patches@freelists.org Hi Gleb, I have one comment, see below. WBR, Alexander Turenko. On Fri, Apr 27, 2018 at 12:53:38PM +0300, Redacted sender "gleb-skiba" for DMARC wrote: > From: Gleb > > Ensure -Werror -Wall set for the whole src/. > Fix warnings which have been found with -Werror and -Wall. > Add new build target RelWithDebInfoWError. > Change build target on RelWithDebInfoWError in CI. > > Fixes #3238 > --- > Issue from https://github.com/tarantool/tarantool/issues/3238. > Source from https://github.com/tarantool/tarantool/tree/gh-3238-check-warnings. > Changes in v3: > -add MAYBE_UNUSED > diff --git a/src/box/sql/alter.c b/src/box/sql/alter.c > index b30a973..a83beea 100644 > --- a/src/box/sql/alter.c > +++ b/src/box/sql/alter.c > @@ -149,7 +149,7 @@ sqlite3AlterFinishAddColumn(Parse * pParse, Token * pColDef) > Column *pCol; /* The new column */ > Expr *pDflt; /* Default value for the new column */ > sqlite3 *db; /* The database connection; */ > - Vdbe *v = pParse->pVdbe; /* The prepared statement under construction */ > + MAYBE_UNUSED Vdbe *v = pParse->pVdbe; /* The prepared statement under construction */ > struct session *user_session = current_session(); > > db = pParse->db; Too long line (more than 80 symbols).