From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id ED07C23952
	for <tarantool-patches@freelists.org>; Fri,  4 May 2018 07:36:46 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id SbVl7PkCLDt3 for <tarantool-patches@freelists.org>;
	Fri,  4 May 2018 07:36:46 -0400 (EDT)
Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id A953823926
	for <tarantool-patches@freelists.org>; Fri,  4 May 2018 07:36:46 -0400 (EDT)
Date: Fri, 4 May 2018 14:36:56 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 3/5] Merge box_error, stat and
 collations into core library
Message-ID: <20180504113656.s7ctowewwzrvfg7x@tkn_work_nb>
References: <cover.1524955403.git.v.shpilevoy@tarantool.org>
 <25b2b52bc741e5c6587a144e000860ef900edab2.1524955403.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <25b2b52bc741e5c6587a144e000860ef900edab2.1524955403.git.v.shpilevoy@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org

Vlad,

One comment is below.

WBR, Alexander Turenko.

On Sun, Apr 29, 2018 at 01:45:11AM +0300, Vladislav Shpilevoy wrote:
> The goal is to expose collations into Lua with no dependencies on
> box library. But collations merge into core requires box_error
> and stat libraries too.

> diff --git a/src/box/lua/call.c b/src/box/lua/call.c
> index be13812aa..b60c6c397 100644
> --- a/src/box/lua/call.c
> +++ b/src/box/lua/call.c
> @@ -30,7 +30,7 @@
>   */
>  #include "box/lua/call.h"
>  #include "box/call.h"
> -#include "box/error.h"
> +#include <error.h>
>  #include "fiber.h"
>  
>  #include "lua/utils.h"
> diff --git a/src/box/lua/error.cc b/src/box/lua/error.cc
> index 314907421..960ea2aa9 100644
> --- a/src/box/lua/error.cc
> +++ b/src/box/lua/error.cc
> @@ -40,7 +40,7 @@ extern "C" {
>  #include <errinj.h>
>  
>  #include "lua/utils.h"
> -#include "box/error.h"
> +#include "src/error.h"
>  
>  static int
>  luaT_error_raise(lua_State *L)

Don't know what policy is in use in Tarantool. The diff above shows two
different approaches to include the same header within the one commit.

It seems that we don't use relative includes (with ..) and prefer either
<> or "src/..." w/o any particular system. Right?