From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CB26021801 for ; Thu, 26 Apr 2018 05:02:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HSAo9A8Moue8 for ; Thu, 26 Apr 2018 05:02:26 -0400 (EDT) Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 16544217CA for ; Thu, 26 Apr 2018 05:02:25 -0400 (EDT) Date: Thu, 26 Apr 2018 12:02:21 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes Message-ID: <20180426090221.mexbuw4iypjqt635@tarantool.org> References: <1524654044-17949-1-git-send-email-gleb-skiba@mail.ru> <20180425151745.zanpo6opqsmh3dhz@tkn_work_nb> <14828071-C85D-4C6A-A985-5372A74A9E61@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <14828071-C85D-4C6A-A985-5372A74A9E61@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" Cc: tarantool-patches@freelists.org, Alexander Turenko , gleb-skiba@mail.ru Hello, On 25 апр 18:44, n.pettik wrote: > > > LGTM. Nikita, can you look? > > Hello. Generally speaking, patch looks OK to me as well. > > I don’t like error message: it is possible to make it more > intelligible. To do it, you need to left parser as is, but in > sqlite3CreateIndex() check that ‘WHERE’ arg is empty. > On the other hand, this is temporary ban and to enable this > feature back, it is enough to revert this patch, so never mind. New test fails for me: /export/kyukhin/tarantool/src/test$ ./test-run.py --builddir ../../bld sql-tap/gh-2165-remove-support-partial-indexes.test.lua ====================================================================================== WORKR TEST PARAMS RESULT --------------------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 534, in run result = self._run(*self.args, **self.kwargs) File "/export/kyukhin/tarantool/src/test-run/lib/test.py", line 38, in _run self.callable(*self.callable_args, **self.callable_kwargs) File "/export/kyukhin/tarantool/src/test-run/lib/app_server.py", line 18, in run_server server.process = Popen(execs, stdout=PIPE, stderr=PIPE, cwd=cwd) File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 534, in __init__ reraise(*exc_info) File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 503, in __init__ restore_signals, start_new_session) File "/usr/lib/python2.7/dist-packages/gevent/subprocess.py", line 1253, in _execute_child raise child_exception OSError: [Errno 13] Permission denied failed with OSError [001] sql-tap/gh-2165-remove-support-partial-indexes.test.lua [001] TAP13 parse failed: Missing plan in the TAP source [001] [ new ] --------------------------------------------------------------------------------- Statistics: * new: 1 -- Regards, Kirill Yukhin