From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1EA4623481 for ; Thu, 26 Apr 2018 02:38:53 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cmpJb2w7hFZd for ; Thu, 26 Apr 2018 02:38:53 -0400 (EDT) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5DA9E2347F for ; Thu, 26 Apr 2018 02:38:51 -0400 (EDT) Received: from [185.6.245.156] (port=52866 helo=tarantool.org) by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1fBaYL-0002G4-Ph for tarantool-patches@freelists.org; Thu, 26 Apr 2018 09:38:49 +0300 Date: Thu, 26 Apr 2018 09:38:49 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH v2] Fix warnings Message-ID: <20180426063849.7mmx4ch3esv3x2cc@tarantool.org> References: <1524503321-23830-1-git-send-email-gleb-skiba@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1524503321-23830-1-git-send-email-gleb-skiba@mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Hello Gleb, On 23 апр 20:08, Gleb wrote: > Ensure -Werror -Wall set for the whole src/. > Fix warnings which have been found with -Werror and -Wall. > Add new build target RelWithDebInfoWError. > Change build target on RelWithDebInfoWError in CI. > > Fixes #3238 > --- > diff --git a/src/box/space_def.c b/src/box/space_def.c > index 22bd3ca..3f11088 100644 > --- a/src/box/space_def.c > +++ b/src/box/space_def.c > @@ -130,6 +130,7 @@ space_def_dup(const struct space_def *src) > * allocation refactoring. > */ > assert(expr_pos_old == expr_pos); > + (void) expr_pos_old; Could you pls use MAYBE_UNUSED, defined in util/trivia.h, instead? (everywhere in your patch) -- Regards, Kirill Yukhin