From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E73C9220B2 for ; Wed, 25 Apr 2018 11:17:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jodPp85ZQRXD for ; Wed, 25 Apr 2018 11:17:37 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2ED8721F82 for ; Wed, 25 Apr 2018 11:17:37 -0400 (EDT) Date: Wed, 25 Apr 2018 18:17:46 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes Message-ID: <20180425151745.zanpo6opqsmh3dhz@tkn_work_nb> References: <1524654044-17949-1-git-send-email-gleb-skiba@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1524654044-17949-1-git-send-email-gleb-skiba@mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Nikita Pettik , Gleb Skiba Cc: tarantool-patches@freelists.org LGTM. Nikita, can you look? Gleb, why do you sent two v3 patches? Also there are no any list of changes of this v3 in comparison to the previous v3. It is for you information, no actions expected from you for now. WBR, Alexander Turenko. On Wed, Apr 25, 2018 at 02:00:44PM +0300, Redacted sender "gleb-skiba" for DMARC wrote: > From: Gleb > > Remove support of partial indexes. > Add test which checks inaccessibility of partial index syntax. > Delete usage of partial index from tests. > They can be enabled after #2626. > > Fixes #2165 > --- > Issue from https://github.com/tarantool/tarantool/issues/2165. > Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes. > Changes in v3: > -return tests which use partial. > -delete "WHERE" from returned tests. > -correct syntax errors in commit