From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 266F021501 for ; Wed, 25 Apr 2018 05:22:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K479H1Ho2hjb for ; Wed, 25 Apr 2018 05:22:51 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6120E20E07 for ; Wed, 25 Apr 2018 05:22:49 -0400 (EDT) Date: Wed, 25 Apr 2018 12:22:56 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial indexes Message-ID: <20180425092256.pwodcjuzivizztcw@tkn_work_nb> References: <1524595147-7195-1-git-send-email-gleb-skiba@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1524595147-7195-1-git-send-email-gleb-skiba@mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Gleb Skiba Cc: tarantool-patches@freelists.org Hi Gleb! Firstly, don't add autogenerated files like parse.c under version control. Add a person you want to respond you into 'To' header and others (including mailing list) in 'Cc'. Just sending a message to the mailing list doesn't trigger any review processes. Send a message with open email to allow direct reply you (not through mailing list). Here your email is shown as dmarc-noreply@freelists.org. Please, fix the patch and ask me for review again. WBR, Alexander Turenko. On Tue, Apr 24, 2018 at 09:39:07PM +0300, Gleb wrote: > Remove support of partial indexes. > Add test which checks inaccessibility of partial index syntax. > Delete usage of partial index from tests. > They can be enabled after #2626. > > Fixes #2165 > --- > Issue from https://github.com/tarantool/tarantool/issues/2165. > Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes. > Changes in v3: > -return tests which use partial. > -delete "WHERE" from returned tests. > -correct syntax errors in commit