From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 24 Apr 2018 18:36:09 +0300 From: Vladimir Davydov Subject: Re: [PATCH v2 2/4] iproto: fix error with unstoppable batching Message-ID: <20180424153609.2yeq5dwtpvc3ojrh@esperanza> References: <23176a3824d858233ee557528659694d60c0de17.1524502856.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <23176a3824d858233ee557528659694d60c0de17.1524502856.git.v.shpilevoy@tarantool.org> To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org List-ID: On Mon, Apr 23, 2018 at 08:05:02PM +0300, Vladislav Shpilevoy wrote: > IProto connection stops input reading, when active request count > is reached. But when multiple requests are in a batch, the IProto > does not check the limit, so it can be violated. > > Lets check the limit during batch parsing after each message too, > not only once before parsing. > --- > src/box/iproto.cc | 29 +++++++++++++++++++---------- > test/box/request_limit.result | 20 ++++++++++++++++++++ > test/box/request_limit.test.lua | 10 ++++++++++ > 3 files changed, 49 insertions(+), 10 deletions(-) Ack