From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 24 Apr 2018 11:04:13 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH 3/3] iproto: allow to configure
 IPROTO_MSG_MAX
Message-ID: <20180424080413.wgvrscmg7epkmbek@esperanza>
References: <cover.1524264646.git.v.shpilevoy@tarantool.org>
 <9a34dae0a53841d2d3f977f1096768396bb2835b.1524264646.git.v.shpilevoy@tarantool.org>
 <20180423113456.4ui5m6w3f4hur2yh@esperanza>
 <b9ae0e94-daf4-9def-42e2-fdb15d7d8674@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b9ae0e94-daf4-9def-42e2-fdb15d7d8674@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Mon, Apr 23, 2018 at 08:00:13PM +0300, Vladislav Shpilevoy wrote:
> > > +		if (cfg_msg.need_update_uri) {
> > > +			if (evio_service_is_active(&binary))
> > > +				evio_service_stop(&binary);
> > > +			if (cfg_msg.uri != NULL)
> > > +				evio_service_bind(&binary, cfg_msg.uri);
> > > +		}
> > > +		if (cfg_msg.need_update_msg_max) {
> > > +			cpipe_set_max_input(&tx_pipe,
> > > +					    cfg_msg.iproto_msg_max / 2);
> > > +			int old = iproto_msg_max;
> > > +			iproto_msg_max = cfg_msg.iproto_msg_max;
> > > +			if (old < iproto_msg_max)
> > > +				iproto_resume();
> > > +		}
> > 
> > This is a matter of personal taste, but I'd prefer to not introduce
> > these extra flags, i.e.
> 
> It is not possible for URI, because URI == NULL is possible update. So
> for URI the flag is necessary. For msg_max I added this for unifying. If you
> want, I can remove need_update_msg_max. Must I do it?

No need then. Leave it as is for consistency.