From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 190952DAF5
	for <tarantool-patches@freelists.org>; Wed, 18 Apr 2018 08:12:56 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id aAzBQjj2580c for <tarantool-patches@freelists.org>;
	Wed, 18 Apr 2018 08:12:56 -0400 (EDT)
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C1A282DAE5
	for <tarantool-patches@freelists.org>; Wed, 18 Apr 2018 08:12:55 -0400 (EDT)
Date: Wed, 18 Apr 2018 15:13:02 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2] Fix warnings
Message-ID: <20180418121302.tnwnkidle3ihyka7@tkn_work_nb>
References: <1523541010-7659-1-git-send-email-gleb-skiba@mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1523541010-7659-1-git-send-email-gleb-skiba@mail.ru>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org

Hi Gleb!

LGTM.

Nikita, can you see the patch?

WBR, Alexander Turenko.

On Thu, Apr 12, 2018 at 04:50:10PM +0300, Gleb wrote:
> Ensure -Werror -Wall set for the whole src/.
> Fix warnings which have been find with -Werror and -Wall.
> Add new building target RelWithDebInfoWError.
> Change building target on RelWithDebInfoWError in CI.
> 
> Fixes #3238
> ---
> Issue from https://github.com/tarantool/tarantool/issues/3238.
> Source from https://github.com/tarantool/tarantool/tree/gh-3238-check-warnings.
>  .travis.mk                 |  4 ++--
>  cmake/compiler.cmake       |  8 +++++++-
>  src/box/space_def.c        |  2 ++
>  src/box/sql/CMakeLists.txt |  3 ---
>  src/box/sql/alter.c        |  1 +
>  src/box/sql/insert.c       |  4 +++-
>  src/box/sql/pragma.c       |  4 ++--
>  src/box/vy_read_iterator.c |  2 +-
>  src/box/xrow.c             | 10 +++++++---
>  src/httpc.c                |  2 +-
>  src/lua/init.c             |  3 ++-
>  src/say.c                  |  7 +++++--
>  12 files changed, 33 insertions(+), 17 deletions(-)

>  	case SAY_LOGGER_BOOT:
>  	{
>  		ssize_t r = safe_write(STDERR_FILENO, buf, total);
>  		(void) r;                       /* silence gcc warning */
> +
>  		break;
>  	}
>  	default:
> -- 
> 2.7.4

This change (extra empty line) is redundant.