From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 18 Apr 2018 14:47:31 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] [wal 1/1] wal: Update request header after
 sequence update
Message-ID: <20180418114731.r2oetxab4md62wo2@esperanza>
References: <c582937d2c9698cc2b63ec6895a78e45410b90aa.1523950414.git.imarkov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c582937d2c9698cc2b63ec6895a78e45410b90aa.1523950414.git.imarkov@tarantool.org>
To: Ilya Markov <imarkov@tarantool.org>
Cc: georgy@tarantool.org, tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Tue, Apr 17, 2018 at 10:39:16AM +0300, Ilya Markov wrote:
> When tuple in insert/replace request has NULL value
> in the field incremented by sequence,
> request body is changed, NULL is replaced by value taken from
> sequence.
> But request header is not updated.
> So Redo log, which takes body from header if header exists,
> writes the old version of request to wal.
> 
> Fixed this with updating header value after handling the sequence.
> 
> Closes #3247
> ---
> branch gh-3247-wrong-sequence-primary-index
> 
>  src/box/request.c              |  7 +++++
>  test/replication/misc.result   | 66 ++++++++++++++++++++++++++++++++++++++++++
>  test/replication/misc.test.lua | 21 ++++++++++++++
>  3 files changed, 94 insertions(+)

Pushed to 1.9.