From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 18 Apr 2018 13:34:26 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH] replication: fix bug with read-only replica as a bootstrap leader Message-ID: <20180418103426.vkjccesutpgj2d4s@esperanza> References: <20180411160227.51871-1-k.belyavskiy@tarantool.org> <20180413085459.x2zuxqufp73r7cmi@esperanza> <1523618014.437515532@f371.i.mail.ru> <20180413123846.wr5s4pnqbdsat5dg@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180413123846.wr5s4pnqbdsat5dg@esperanza> To: Konstantin Belyavskiy Cc: tarantool-patches@freelists.org, georgy List-ID: On Fri, Apr 13, 2018 at 03:38:46PM +0300, Vladimir Davydov wrote: > On Fri, Apr 13, 2018 at 02:13:34PM +0300, Konstantin Belyavskiy wrote: > > Please take a look at newer version. > > When you fix something like this, please include the new version of the > patch in the email. > > The patch itself looks OK to me. Posting it here for the record. > > > From 983b98a91dcd70a3013de373b55294a6af468e17 Mon Sep 17 00:00:00 2001 > > From: Konstantin Belyavskiy > > Date: Mon, 9 Apr 2018 16:32:26 +0300 > > Subject: [PATCH] replication: fix bug with read-only replica as a bootstrap > > leader > > > > When bootstrapping a new cluster, each replica from replicaset can > > be chosen as a leader, but if it is 'read-only', bootstrap will > > failed with an error. > > Fixed it by eliminating read-only replicas from voting by adding > > access rights information to IPROTO_REQUEST_VOTE reply. > > > > Closes #3257 Pushed to 1.9.