From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A77CC2E8B6 for ; Wed, 18 Apr 2018 01:42:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z5cji8uPBsaa for ; Wed, 18 Apr 2018 01:42:26 -0400 (EDT) Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F24662E8B5 for ; Wed, 18 Apr 2018 01:42:25 -0400 (EDT) Date: Wed, 18 Apr 2018 08:42:21 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] sql: use collation pointers instead of names Message-ID: <20180418054221.qsc3czyt2ilrt5lt@tarantool.org> References: <9df9979a-86a9-fe60-219d-487f4d74dd14@tarantool.org> <23455f13-95ed-40b8-de72-610b1e9fba19@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <23455f13-95ed-40b8-de72-610b1e9fba19@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Vladislav Shpilevoy Cc: tarantool-patches@freelists.org Hello Vlad, On 17 апр 21:06, Vladislav Shpilevoy wrote: > Hello. Thanks for fixes, but you did not all of them. I > pushed my fixes as a separate commit on your branch. Please, > look at them, squash into your commit, and then the patch > will be ok for me. Thanks. I've squashed your changes in and committed final patch to 2.1 branch. -- Regards, Kirill Yukhin > On 17/04/2018 08:35, Kirill Yukhin wrote: > > Before the change SQL FE used collation names to refer to > > collations. Main data structures were using names as well. > > The patch fixes that and uses explicit pointers to Tarantool's > > `struct coll` during code gen and inside data structures. > > > > Closes #3205