From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 13A962353D for ; Tue, 17 Apr 2018 04:58:15 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i0EU434DuFwF for ; Tue, 17 Apr 2018 04:58:14 -0400 (EDT) Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 36ED82A4C5 for ; Tue, 17 Apr 2018 04:58:13 -0400 (EDT) Date: Tue, 17 Apr 2018 11:58:10 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH] Remove autogenerated files Message-ID: <20180417085810.bkmbzcpsk4w2gvao@tarantool.org> References: <1141305d49839770c3951674c47a8ae2cb303c62.1523167474.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1141305d49839770c3951674c47a8ae2cb303c62.1523167474.git.alexander.turenko@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Alexander Turenko Cc: Nikita Pettik , tarantool-patches@freelists.org Hello Alex! Overall approach LGTM. The only input I have here: could you pls put all generated files into build directory. This will allow OOB to retain source dir in virgin pure state. -- Regards, Kirill Yukhin On 08 апр 11:31, Alexander Turenko wrote: > Rewrote TCL scripts as posix shell ones, enabled SQL_MAINTAINER_MODE > commands unconditionally. > > Fixes #3183.