From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 9 Apr 2018 23:51:22 +0300 From: Konstantin Osipov Subject: Re: [PATCH 11/12] vinyl: force index rebuild if indexed field type is narrowed Message-ID: <20180409205122.GL4527@atlas> References: <4b365a15c97a90c49d5394765b0953bcf775b5bf.1523105106.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b365a15c97a90c49d5394765b0953bcf775b5bf.1523105106.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/04/09 10:33]: > If the type of an indexed field is narrowed (e.g. is_nullable flag is > cleared or the type is changed from 'integer' to 'unsigned'), but the > index structure remains the same (same fields, indexed in the same > order), we won't rebuild the index, instead we will check that all > tuples stored in the space conform to the new format (CheckSpaceFormat) > and if so modify the index in-place (ModifyIndex). This is OK for memtx, > but not for Vinyl, because even if the space contains no tuples > conflicting with the new format, there may be overwritten or deleted > statements, which can't be detected by CheckSpaceFormat. OK to push. > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov