From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 9 Apr 2018 23:49:55 +0300 From: Konstantin Osipov Subject: Re: [PATCH 10/12] vinyl: remove superfluous ddl checks Message-ID: <20180409204955.GK4527@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/04/09 10:33]: > There's no need to iterate over all indexes in vinyl_space_prepare_alter > and check if any of them is going to be rebuilt - alter_space_do already > does that for us. All we need to do is raise an error if the build_index > callback is invoked for a non-empty space after recovery is complete. > The tuple format check is pointless too, as it is already done by > CheckSpaceFormat AlterSpaceOp. Remove them. Nice. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov