From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 9 Apr 2018 23:34:03 +0300 From: Konstantin Osipov Subject: Re: [PATCH 04/12] alter: use space_index instead of index_find where appropriate Message-ID: <20180409203403.GE4527@atlas> References: <8e2e1d73d9714d8f5c4431c8b59a96bfd5b392d2.1523105106.git.vdavydov.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8e2e1d73d9714d8f5c4431c8b59a96bfd5b392d2.1523105106.git.vdavydov.dev@gmail.com> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Vladimir Davydov [18/04/09 10:33]: > Using index_find_xc() in AlterSpaceOp::commit and rollback is > confusing, because these functions may not throw. Let's use > space_index instead as we are sure that the index we are looking > for must exist. While we are at it, add some missing assertions. OK to push. -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov