From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 9 Apr 2018 17:07:33 +0300 From: Vladimir Davydov Subject: Re: [PATCH v2] replication: fix bug with zero replication_connect_quorum Message-ID: <20180409140733.j4tfgetd65qaj2g6@esperanza> References: <20180409103530.21415-1-k.belyavskiy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180409103530.21415-1-k.belyavskiy@tarantool.org> To: Konstantin Belyavskiy Cc: georgy@tarantool.org, tarantool-patches@freelists.org List-ID: The patch looks good to me. On Mon, Apr 09, 2018 at 01:35:30PM +0300, Konstantin Belyavskiy wrote: > If 'box.cfg.read_only' is false, 'replication' defines at least one > replica (other than itself), but they are not available at the time > of box.cfg execution and replication_connect_quorum is set to zero, > master displays 'orphan' status instead of 'running' since logic > which cnange this state is executed only after successfull connection. > > Changes in v2: > Change test to @locker version. > > ticket: https://github.com/tarantool/tarantool/issues/3278 > branch: https://github.com/tarantool/tarantool/compare/gh-3278-fix-bug-with-zero-replication-connect-quorum This should go after --- below (it is ignored by git-am then). > > Closes #3278 > --- > src/box/replication.cc | 8 +++-- > test/replication/quorum.result | 66 ++++++++++++++++++++++++++++++++++ > test/replication/quorum.test.lua | 22 ++++++++++++ > test/replication/replica_no_quorum.lua | 11 ++++++ > 4 files changed, 105 insertions(+), 2 deletions(-) > create mode 100644 test/replication/replica_no_quorum.lua