From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 5 Apr 2018 17:48:49 +0300 From: Konstantin Osipov Subject: Re: [PATCH 12/12] vinyl: allow to modify key definition if it does not require rebuild Message-ID: <20180405144849.GB17397@atlas> References: <20180402084649.dxtykpka5tylrgn2@esperanza> <20180405144503.GA17397@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180405144503.GA17397@atlas> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: * Konstantin Osipov [18/04/05 17:45]: > One more thing, please, we need more functional tests. > > Let's create a test plan which we will then reuse for non-empty > spaces as well: > > Modify: > - unique -> non unique, non-unique -> unique, or no change > - nullable -> not-nullable, not-nullable -> nullable, or no > change > - a wider type is altered to a more narrow type, or vice versa, > or the type types are incompatible, or no change, > - key part added, removed, or all key parts changed, or no key > parts changed. A few more dimensions: - engine=memtx or engine=vinyl. - a space format is defined or not - a space is empty or not - the alter happens during run time, replica join, or WAL recovery -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.io - www.twitter.com/kostja_osipov