From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 388E02D387 for ; Thu, 5 Apr 2018 10:12:33 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yGIShkzNZ-T6 for ; Thu, 5 Apr 2018 10:12:33 -0400 (EDT) Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EA10E2D34D for ; Thu, 5 Apr 2018 10:12:32 -0400 (EDT) Date: Thu, 5 Apr 2018 17:12:30 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/2] rework SQL 'DROP' routine Message-ID: <20180405141230.wxn565zan3cfcbps@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik Hello Nikita, On 03 апр 19:14, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/gh-3222-rework-drop > Issue: https://github.com/tarantool/tarantool/issues/3222 > > This small patch-set implements part of #3222 issue: rewrite functions > implementing drop table and drop index in order to avoid using > struct Table and its lookup in SQLite data-dictionary. > However, as far as currently triggers aren't part of Tarantool's spaces, > it is still required to use struct Table to drop them: > triggers are held in _trigger space, which format is: ['name', 'sql'], > i.e. there is no field for name of parent table. Hence, we are able > to point out table's triggers only via accessing struct Table. > > Both patches are mainly about refactoring. > First patch removes useless wrappers, obsolete SQLite specific functions > and struct fields. > Second one replaces usages of struct Table with struct space in drop > routine, fixes codestyle, provides doxygen style comments. > > Nikita Pettik (2): > sql: remove obsolete SQLite routine > sql: rework 'DROP INDEX' and 'DROP TABLE' handling Patchset looks perfect now, I've checked it into 2.0. -- Regards, Kirill Yukhin