From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EDE312D3D5
	for <tarantool-patches@freelists.org>; Thu,  5 Apr 2018 08:19:54 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id p_TPOMrZMh0E for <tarantool-patches@freelists.org>;
	Thu,  5 Apr 2018 08:19:54 -0400 (EDT)
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 46C8C2D38A
	for <tarantool-patches@freelists.org>; Thu,  5 Apr 2018 08:19:54 -0400 (EDT)
Date: Thu, 5 Apr 2018 15:19:51 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2] sql: ban of REINDEX syntax
Message-ID: <20180405121951.g45tg5hj263iwiuw@tarantool.org>
References: <1522845032-25749-1-git-send-email-vanyail@yandex.ru>
 <372ED065-AD77-48BE-A098-CFB74EF893A2@tarantool.org>
 <20180404155616.g6ew4uqc3imouawd@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180404155616.g6ew4uqc3imouawd@tkn_work_nb>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: vanyail <vanyail@yandex.ru>, "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org

Hello Ivan, Sasha.
On 04 апр 18:56, Alexander Turenko wrote:
> Kirill, can you catch this patch?
> 
> I gave my LGTM in the separate branch of this mail thread.
> 
> WBR, Alexander Turenko.
> 
> On Wed, Apr 04, 2018 at 06:42:10PM +0300, n.pettik wrote:
> > Hello. See only one minor remark. The rest seems OK to me.
> > 
> > > On 4 Apr 2018, at 15:30, Ivan Ilyin <vanyail@yandex.ru> wrote:
> > > 
> > > From: vanyail <vanyail@yandex.ru>
> > > 
> > > This change removes REINDEX from keywords and also disables tests
> > > which were using this syntax.
> > > 
> > > This patch affects only parser, REINDEX implementation still exists,
> > > because it is planned to be fixed and enabled in the scope of #3195.
> > > 
> > > Note that REINDEX keyword is still in '%fallback' directive in
> > > 'parse.y'. Reserved keywords included there to avoid situation when
> > > a keyword has no usages within 'parse.y' file.
> > > 
> > > Fixes #2174
> > > branch: https://github.com/tarantool/tarantool/tree/gh-2174-ban-reindex-syntax
> > > issue: https://github.com/tarantool/tarantool/issues/2174
The error message confuses me as well. But let's go with it, since we'll
probably re-enable REINDEX soon.

I've checked your patch in to 2.0.

--
Regards, Kirill Yukhin

> > > ---
> > > src/box/sql/parse.c                              | 1797 +++++++++++-----------
> > > src/box/sql/parse.y                              |   18 +-
> > > test/sql-tap/gh-2174-ban-reindex-syntax.test.lua |   29 +
> > > test/sql-tap/gh2130-index-refer-table.test.lua   |   23 +-
> > > test/sql-tap/misc3.test.lua                      |   73 +-
> > > test/sql-tap/suite.ini                           |    2 +
> > > 6 files changed, 980 insertions(+), 962 deletions(-)
> > > create mode 100755 test/sql-tap/gh-2174-ban-reindex-syntax.test.lua
> > > 
> > > ...