From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 39AF42D0DE for ; Thu, 5 Apr 2018 07:43:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eKjLnxOexzg7 for ; Thu, 5 Apr 2018 07:43:09 -0400 (EDT) Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EE15C2D05C for ; Thu, 5 Apr 2018 07:43:08 -0400 (EDT) Date: Thu, 5 Apr 2018 14:43:05 +0300 From: Kirill Yukhin Subject: [tarantool-patches] Re: [PATCH 0/4] sql: refactor insertion and lua Message-ID: <20180405114305.oefl47b4hky7xlty@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: korablev@tarantool.org, Vladislav Shpilevoy Hello Vlad, On 03 апр 18:34, Vladislav Shpilevoy wrote: > Branch: http://github.com/tarantool/tarantool/tree/gh-2618-preliminary-patches > Issue: https://github.com/tarantool/tarantool/issues/2618 > > The patchset consists of patches preliminary to SQL IProto > "last updated tuple" introduction. It is possible, that its > implementation plan will be changed several times, but this > patchset looks useful even with no IProto "last updated tuple". > > 1) The patch does SQL INSERT/UPDATE refactoring by removal of 2 > unused VDBE parameters, and by restyling of final insertion > opcodes generator: sqlite3CompleteInsertion. > > 2) The patch does refactoring of Lua SQL executor, that is > extremely overengineered now. > > Vladislav Shpilevoy (4): > sql: remove unused opcodes from OP_[Sorter/Idx][Insert/Replace] > sql: remove unused error codes, use enum instead of defines > sql: simplify lua SQL executor > sql: remove useless branching in insertOrReplace The patchset LGTM. I've comitted it to 2.0 -- Regards, Kirill Yukhin