From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C2B3D2A898
	for <tarantool-patches@freelists.org>; Wed,  4 Apr 2018 08:54:21 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id D8UCSidxJZds for <tarantool-patches@freelists.org>;
	Wed,  4 Apr 2018 08:54:21 -0400 (EDT)
Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8217C2A6AC
	for <tarantool-patches@freelists.org>; Wed,  4 Apr 2018 08:54:21 -0400 (EDT)
Date: Wed, 4 Apr 2018 15:54:26 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2] sql: ban of REINDEX syntax
Message-ID: <20180404125426.f5ujpumkahz6n5jf@tkn_work_nb>
References: <1522845032-25749-1-git-send-email-vanyail@yandex.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1522845032-25749-1-git-send-email-vanyail@yandex.ru>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: vanyail <vanyail@yandex.ru>, "n.pettik" <korablev@tarantool.org>
Cc: tarantool-patches@freelists.org

Hi, Ivan!

The commit is LGTM. Nikita, can you look into this?

Notes for future contributions: please, place comments like brach/issue
*under* --- mark. Also it would be good to include changelog since first
proposed version into v2 message (also under --- mark).

WBR, Alexander Turenko.

On Wed, Apr 04, 2018 at 03:30:32PM +0300, Ivan Ilyin wrote:
> From: vanyail <vanyail@yandex.ru>
> 
> This change removes REINDEX from keywords and also disables tests
> which were using this syntax.
> 
> This patch affects only parser, REINDEX implementation still exists,
> because it is planned to be fixed and enabled in the scope of #3195.
> 
> Note that REINDEX keyword is still in '%fallback' directive in
> 'parse.y'. Reserved keywords included there to avoid situation when
> a keyword has no usages within 'parse.y' file.
> 
> Fixes #2174
> branch: https://github.com/tarantool/tarantool/tree/gh-2174-ban-reindex-syntax
> issue: https://github.com/tarantool/tarantool/issues/2174
> ---
>  src/box/sql/parse.c                              | 1797 +++++++++++-----------
>  src/box/sql/parse.y                              |   18 +-
>  test/sql-tap/gh-2174-ban-reindex-syntax.test.lua |   29 +
>  test/sql-tap/gh2130-index-refer-table.test.lua   |   23 +-
>  test/sql-tap/misc3.test.lua                      |   73 +-
>  test/sql-tap/suite.ini                           |    2 +
>  6 files changed, 980 insertions(+), 962 deletions(-)
>  create mode 100755 test/sql-tap/gh-2174-ban-reindex-syntax.test.lua
> 
> ...