From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Sun, 1 Apr 2018 12:37:11 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH v2 0/2] schema: expose space_mt and index_mt on
 box.schema table
Message-ID: <20180401093711.dc3b3gnptfnn6n7u@esperanza>
References: <20180329105446.v427bzpwichq5ntb@esperanza>
 <cover.1522333878.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1522333878.git.v.shpilevoy@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Thu, Mar 29, 2018 at 05:31:43PM +0300, Vladislav Shpilevoy wrote:
> Branch: http://github.com/tarantool/tarantool/tree/pr-3204-expose-space-index-mt
> Issue: https://github.com/tarantool/tarantool/issues/3204

Nit-picking: change log is missing, see

https://tarantool.io/en/doc/1.9/dev_guide/developer_guidelines.html#how-to-submit-a-patch-for-review

> 
> Vladislav Shpilevoy (1):
>   schema: expose space_mt and index_mt on `box.schema` table
> 
> aleclarson (1):
>   schema: move space_mt and index_mt definition out of space bless

Please remove Alec from here.

> 
>  src/box/lua/schema.lua          | 631 ++++++++++++++++++++--------------------
>  test/box-tap/schema_mt.test.lua |  79 +++++
>  2 files changed, 391 insertions(+), 319 deletions(-)
>  create mode 100755 test/box-tap/schema_mt.test.lua