From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D2FBF2A1B3 for ; Thu, 29 Mar 2018 06:10:25 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L-GuaDIjxRle for ; Thu, 29 Mar 2018 06:10:25 -0400 (EDT) Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 921B22A19E for ; Thu, 29 Mar 2018 06:10:25 -0400 (EDT) Date: Thu, 29 Mar 2018 13:10:29 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] sql: remove support of partial indexes Message-ID: <20180329101028.kutvgeay23dtqgpq@tkn_work_nb> References: <1521937705-8170-1-git-send-email-gleb-skiba@mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1521937705-8170-1-git-send-email-gleb-skiba@mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Gleb Cc: tarantool-patches@freelists.org Hi, Gleb! Please, squash your two commits into one and resend the patch. WBR, Alexander Turenko. On Sun, Mar 25, 2018 at 03:28:25AM +0300, Gleb wrote: > Issue from https://github.com/tarantool/tarantool/issues/2165. > Source from https://github.com/tarantool/tarantool/tree/gh-2165-remove-support-partial-indexes. Place it under --- mark. > Remove support partial indexes. > Add test which check inaccessibility of partial index syntax. > Comment tests which use partial index, they can be uncomment when partial index will be available. The line length exceeds 72 symbols. > Fixed comments as per review. That should not be part of the commit message. > > Fixes #2165 > --- Here you should place issue/branch names, changelog and other things that should not be part of the commit. > src/box/sql/build.c | 11 +- > src/box/sql/parse.c | 205 +++++++++--------- > src/box/sql/parse.y | 2 +- > test/sql-tap/analyze9.test.lua | 18 +- > test/sql-tap/autoindex4.test.lua | 5 +- > test/sql-tap/fkey1.test.lua | 1 - > test/sql-tap/index6.test.lua | 437 +++++++++++++++++++-------------------- > test/sql-tap/suite.ini | 1 + > 8 files changed, 333 insertions(+), 347 deletions(-) > > ... > > diff --git a/test/sql-tap/analyze9.test.lua b/test/sql-tap/analyze9.test.lua > index 472bad7..206ae16 100755 > --- a/test/sql-tap/analyze9.test.lua > +++ b/test/sql-tap/analyze9.test.lua > ... > @@ -1177,9 +1172,9 @@ test:do_execsql_test( > -- [[ > -- EXPLAIN QUERY PLAN SELECT * FROM t1 WHERE d IS NOT NULL AND a=0 AND b=0 AND c=10; > -- ]], { > --- -- <17.6> > + -- <17.6> > -- 0, 0, 0, "SEARCH TABLE T1 USING COVERING INDEX I2 (C=? AND D>?)" > --- -- > + -- > -- }) > Use -- *at start* of each line for the entire block or --[[ ... ]]--. I'm about '<17.6>' lines. > diff --git a/test/sql-tap/suite.ini b/test/sql-tap/suite.ini > index 0bc9e83..d6ce75e 100644 > --- a/test/sql-tap/suite.ini > +++ b/test/sql-tap/suite.ini > @@ -3,3 +3,4 @@ core = app > description = Database tests with #! using TAP > lua_libs = lua/sqltester.lua ../sql/lua/sql_tokenizer.lua ../box/lua/identifier.lua > is_parallel = True > +disabled = index6.test.lua; Space before ';' is needed according to [1]. Write a comment with the issue re partial index enabling (#2626), please. > -- > 2.7.4 >