From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 28 Mar 2018 14:16:15 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [commits] [tarantool] 03/04: bloom: optimize tuple bloom filter
 size
Message-ID: <20180328111615.5fltx74ujvp26dry@esperanza>
References: <20180327210817.GB11829@atlas>
 <20180327210938.GC11829@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180327210938.GC11829@atlas>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org, commits@tarantool.org
List-ID: <tarantool-patches.dev.tarantool.org>

On Wed, Mar 28, 2018 at 12:09:38AM +0300, Konstantin Osipov wrote:
> * Vladimir Davydov <vdavydov.dev@gmail.com> [18/03/21 16:36]:
> > 
> 
> Please add references to the papers you have been using to
> construct the hash functions and calculate the theoretical false
> positive rate. 

They are already in bloom.h, thanks to Alexander Lyapunov.

> 
> In future, It would be nice to actually have stats about actual false
> positive rates so that we know if the papers are BS or not.

We already have bloom.hit and bloom.miss stat counters in index.info()
so we can calculate the false positive rate as

  bloom.miss / (bloom.hit + bloom.miss)

> 
> Otherwise this part is OK.