From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Wed, 28 Mar 2018 13:20:52 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH v2 1/1] tuple:tomap: only_names
 option
Message-ID: <20180328102052.c5vrvozwvdjpvscy@esperanza>
References: <b9c53caf-7c00-6bef-3e90-c71f519553fe@tarantool.org>
 <1397a5af1ab577c4a04c14a2ccb779b34fa21de3.1522162837.git.kshcherbatov@tarantool.org>
 <33B37A8B-180B-44D6-83E9-A10F028D03A3@tarantool.org>
 <22af426b-439b-ef31-893d-1e677d1a478e@tarantool.org>
 <c248ce2c-4ec3-bd86-a6c6-1bc96f49b663@tarantool.org>
 <50FD81D5-916C-4E8C-B32B-1234729D0B40@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50FD81D5-916C-4E8C-B32B-1234729D0B40@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

Ack, but please in future add more descriptive comments to your patches.
In this particular case it would be nice to have a description of the
new option in the commit log (what it does, an example of usage).

> From 14a62b394bf7b21d6c9549875abce5c71416c0b3 Mon Sep 17 00:00:00 2001
> From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
> Date: Wed, 28 Mar 2018 11:05:19 +0300
> Subject: [PATCH] tuple:tomap: only_names option
> 
> Fixes #3280
> 
>  src/box/lua/tuple.c        | 22 +++++++++++++--
>  test/engine/tuple.result   | 69 ++++++++++++++++++++++++++++++++++++++++++++++
>  test/engine/tuple.test.lua | 21 ++++++++++++++
>  3 files changed, 110 insertions(+), 2 deletions(-)