From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 27 Mar 2018 19:26:56 +0300 From: Vladimir Davydov Subject: Re: [tarantool-patches] Re: [PATCH v2 1/1] netbox: show is_nullable and collation fields Message-ID: <20180327162656.xn7zg3skjgbnmf4m@esperanza> References: <82848BBB-2A50-4CAC-852E-E5EE5C8247A3@tarantool.org> <02f53c50-c3eb-9e8c-6d15-9adfb7d23c0d@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <02f53c50-c3eb-9e8c-6d15-9adfb7d23c0d@tarantool.org> To: Kirill Shcherbatov Cc: "v.shpilevoy@tarantool.org" , tarantool-patches@freelists.org List-ID: On Mon, Mar 26, 2018 at 08:41:21PM +0300, Kirill Shcherbatov wrote: > diff --git a/test/box/net.box.test.lua b/test/box/net.box.test.lua > index fe45721..3b4ce05 100644 > --- a/test/box/net.box.test.lua > +++ b/test/box/net.box.test.lua > @@ -799,11 +799,9 @@ > box.schema.user.revoke('guest','read,write,execute','universe') >=20 > =A0space:drop() >=20 > - > =A0-- > =A0-- gh-3256 net.box is_nullable and collation options output > =A0-- > - > =A0space =3D box.schema.create_space('test') > =A0box.schema.user.grant('guest','read,write,execute','space', 'test') > =A0pk =3D space:create_index('pk') > @@ -821,4 +819,5 @@ c =3D net:connect(box.cfg.listen) > =A0c.space.test.index.sk.parts > =A0c:close() > =A0box.internal.collation.drop('test') > -space:drop() > \ No newline at end of file > +space:drop() > + Nit-pick: extra newline at the end of the file. We always add exactly one newline symbol at the end of each source file. In v1 you added no newline at all, in v2 you added two newline symbols. Please fix your editor configuration. Other than that, the patch is fine by me.