From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vdavydov.dev@gmail.com>
Date: Tue, 27 Mar 2018 18:32:03 +0300
From: Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH] Clear session storage on session stop
Message-ID: <20180327153203.x7h55y5ohcialqgs@esperanza>
References: <6f3087cb542e9a56f53730a2638686ce2e333527.1522156730.git.georgy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6f3087cb542e9a56f53730a2638686ce2e333527.1522156730.git.georgy@tarantool.org>
To: Georgy Kirichenko <georgy@tarantool.org>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

Looks good to me.

On Tue, Mar 27, 2018 at 04:29:14PM +0300, Georgy Kirichenko wrote:
> * session_run_on_disconnect_triggers is called only if there are
> corresponding triggers so move session_storage_cleanup to
> session_destroy.
> * fix session storage cleanup path: use
> "box.session.aggregate_storage[sid]" instead of
> "session.aggregate_storage[sid]" (what was wrong)
> 
> Fixed #3279
> ---
> https://github.com/tarantool/tarantool/tree/gh-3279-clear-session-storage
> 
>  src/box/lua/session.c                 | 3 +++
>  src/box/session.cc                    | 2 +-
>  test/box-tap/session.storage.test.lua | 2 +-
>  3 files changed, 5 insertions(+), 2 deletions(-)