From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 22 Mar 2018 22:37:07 +0300 From: Konstantin Osipov Subject: Re: [tarantool-patches] [PATCH 3/3] netbox: deprecate console support Message-ID: <20180322193707.GC18129@atlas> References: <95b811a3aa73edc02c58dcd6fb475155498457d5.1521745741.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95b811a3aa73edc02c58dcd6fb475155498457d5.1521745741.git.v.shpilevoy@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Vladislav Shpilevoy List-ID: * Vladislav Shpilevoy [18/03/22 22:18]: > Print warning about that. After a while the cosole support will > be deleted from netbox. > --- > src/box/lua/net_box.lua | 6 ++++++ > 1 file changed, 6 insertions(+) This is a no-brainer. > > diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua > index f3f69f52f..cf1a04237 100644 > --- a/src/box/lua/net_box.lua > +++ b/src/box/lua/net_box.lua > @@ -396,7 +396,10 @@ local function create_transport(host, port, user, password, callback, > if err then > return error_sm(err, msg) > end > + -- @deprecated since 1.10 > if greeting.protocol == 'Lua console' then > + log.warn("Netbox text protocol support is deprecated since 1.10, ".. > + "please use require('console').connect() instead") > local setup_delimiter = 'require("console").delimiter("$EOF$")\n' > method_codec.inject(send_buf, nil, nil, setup_delimiter) > local err, response = send_and_recv_console() > @@ -673,7 +676,10 @@ local function do_connect(host, port, opts, existing_connection, greeting) > end > end > end > + -- @deprecated since 1.10 > if opts.console then > + log.warn("Netbox console API is deprecated since 1.10, please use ".. > + "require('console').connect() instead") > setmetatable(remote, console_mt) > else > setmetatable(remote, remote_mt) > -- > 2.14.3 (Apple Git-98) > > -- Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 http://tarantool.org - www.twitter.com/kostja_osipov