From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 52BA527FD0 for ; Wed, 21 Mar 2018 16:10:32 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8bT4qrJj9gDE for ; Wed, 21 Mar 2018 16:10:32 -0400 (EDT) Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8832A2758E for ; Wed, 21 Mar 2018 16:10:31 -0400 (EDT) Date: Wed, 21 Mar 2018 23:10:31 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] sql: ban of REINDEX syntax Message-ID: <20180321201031.gqoyg4mf2mb3q6sj@tkn_work_nb> References: <1521120892.753756821@f173.i.mail.ru> <1521630368-2969-1-git-send-email-vanyail@yandex.ru> <20180321130224.7in37pr56xg6h5cr@tkn_work_nb> <4A8FE286-3EDE-460F-8AAA-6A643104B41A@tarantool.org> <20180321160830.mmqdfaosyb7ghfgw@tkn_work_nb> <20180321164252.iiwzs23vgn6srtl5@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180321164252.iiwzs23vgn6srtl5@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Ivan Ilyin , tarantool-patches@freelists.org Cc: Nikita Pettik , Kirill Yukhin Ivan, please consider decisions below, update the commit and send it again. WBR, Alexander Turenko. On Wed, Mar 21, 2018 at 07:42:52PM +0300, Kirill Yukhin wrote: > On 21 мар 19:08, Alexander Turenko wrote: > > Kirill, can you suggest best ways to go forward on detable questions > > below? > I think there're no specific ways to raise such. If you'd like to bring > my attention: CC me explicitly in e-mail. > > > > > On Wed, Mar 21, 2018 at 06:37:38PM +0300, n.pettik wrote: > > > Hello. See comments below. > > > > > > >This change cut > > > > > > Misspelling: cut(s). > > > > > > >The reason described in 'parse.y' in comment related > > > >to '%fallback'. > > > > > > Don't reffer to comments in your commit message. Instead, provide > > > short desctiption/explanation. > > > > > > > Why we need to duplicate explanation? A commit message is a part of the > > commit. > You might break commit-comment connection by commits that follows. > Proposed to describe it shortly in the commit message like so: Note that REINDEX keyword is still in '%fallback' directive in 'parse.y', because we need at least one usage of a keyword in 'parse.y' to prevent exclusion from 'parse.h' (it would break the build). > > > >+++ b/src/box/sql/parse.y > > > >@@ -202,6 +202,17 @@ columnname(A) ::= nm(A) typetoken(Y). {sqlite3AddColumn(pParse,&A,&Y);} > > > >// fallback to ID if they will not parse as their original value. > > > >// This obviates the need for the "id" nonterminal. > > > >// > > > >+// A keyword is checked for being a reserve one in `nm`, before > > > >+// processing of this %fallback directive. Reserved keywords included > > > >+// here to avoid the situation when a keyword has no usages within > > > >+// `parse.y` file (a keyword can have more or less usages depending on > > > >+// compiler defines). When a keyword has no usages it is excluded > > > >+// from autogenerated file `parse.h` that lead to compile-time error. > > > >+// > > > >+// See [1] for more information. > > > >+// > > > >+// [1]: https://www.sqlite.org/src/info/007aec11333432e0 > > > >+// > > > > > > I would better put link to commit message or to comments of original > > > issue. I stick to the point that source code doesn't seem to be good > > > place for links. Also, in Tarantool we use C-like commenting style. > > > > > > > I don't see nothing bad with using links, epsecially when it can > > simplify reader experience. > IMHO, internet is volatile. WWW-links are not verbatim enough to me, and > hence are fallcious artifacts to put into comment. I'd defer final decision > to 1st level reviewer. > Link with SHA1 is better IMO than just SHA1, but I understood that the point is about our feelings of the code we write. Proposed to include it like so: See fossil check-in [007aec11] or CVS commit 2045 in SQLite for more information.