From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5AD782CB8C for ; Wed, 21 Mar 2018 12:08:29 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P9E7lbP_2wJ7 for ; Wed, 21 Mar 2018 12:08:29 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 18B412CB82 for ; Wed, 21 Mar 2018 12:08:28 -0400 (EDT) Date: Wed, 21 Mar 2018 19:08:30 +0300 From: Alexander Turenko Subject: [tarantool-patches] Re: [PATCH] sql: ban of REINDEX syntax Message-ID: <20180321160830.mmqdfaosyb7ghfgw@tkn_work_nb> References: <1521120892.753756821@f173.i.mail.ru> <1521630368-2969-1-git-send-email-vanyail@yandex.ru> <20180321130224.7in37pr56xg6h5cr@tkn_work_nb> <4A8FE286-3EDE-460F-8AAA-6A643104B41A@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4A8FE286-3EDE-460F-8AAA-6A643104B41A@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Yukhin , Nikita Pettik Cc: vanyail@yandex.ru Kirill, can you suggest best ways to go forward on detable questions below? On Wed, Mar 21, 2018 at 06:37:38PM +0300, n.pettik wrote: > Hello. See comments below. > > >This change cut > > Misspelling: cut(s). > > >The reason described in 'parse.y' in comment related > >to '%fallback'. > > Don't reffer to comments in your commit message. Instead, provide > short desctiption/explanation. > Why we need to duplicate explanation? A commit message is a part of the commit. > >+++ b/src/box/sql/parse.y > >@@ -202,6 +202,17 @@ columnname(A) ::= nm(A) typetoken(Y). {sqlite3AddColumn(pParse,&A,&Y);} > >// fallback to ID if they will not parse as their original value. > >// This obviates the need for the "id" nonterminal. > >// > >+// A keyword is checked for being a reserve one in `nm`, before > >+// processing of this %fallback directive. Reserved keywords included > >+// here to avoid the situation when a keyword has no usages within > >+// `parse.y` file (a keyword can have more or less usages depending on > >+// compiler defines). When a keyword has no usages it is excluded > >+// from autogenerated file `parse.h` that lead to compile-time error. > >+// > >+// See [1] for more information. > >+// > >+// [1]: https://www.sqlite.org/src/info/007aec11333432e0 > >+// > > I would better put link to commit message or to comments of original > issue. I stick to the point that source code doesn't seem to be good > place for links. Also, in Tarantool we use C-like commenting style. > I don't see nothing bad with using links, epsecially when it can simplify reader experience. WBR, Alexander Turenko.