From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6543929636 for ; Wed, 29 Aug 2018 02:07:36 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DVSTgzplGgRY for ; Wed, 29 Aug 2018 02:07:36 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C9AF8295F1 for ; Wed, 29 Aug 2018 02:07:35 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [PATCH v3] Tarantool static build ability Date: Wed, 29 Aug 2018 09:07:27 +0300 Message-ID: <2016958.MVsY5zT6Ff@home.lan> In-Reply-To: <20180829012547.r6nepf4uomq272f2@tkn_work_nb> References: <24642c7850be9d422ea76d96fbcf342bf20f1e5f.1535486630.git.georgy@tarantool.org> <20180829012547.r6nepf4uomq272f2@tkn_work_nb> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart139620925.hoJTvvvH1q"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Alexander Turenko Cc: tarantool-patches@freelists.org --nextPart139620925.hoJTvvvH1q Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday, August 29, 2018 4:25:47 AM MSK Alexander Turenko wrote: I sent fixed branch and a message. Please look on my comments inline > Hi, Georgy! > > I have minor notes on the code and some experimenting results. Please, > especially consider attempt to use docker at end of the email. > > I don't think I can add more value on the next review rounds, so, > please, proceed with the next reviewer (I guess Kirill Yu.) if the > process allows it. > > WBR, Alexander Turenko. > > ---- Updates ---- > > Included cmake file has the same line at the line 374 (fixed in the our > repo, of cource, see the first review, where I show the diff). Fixed > Are not pthread should follows gomp? nm reports undefined static symbols > starts with 'pthread_' in libgomp.a. Fixed > libcurl.a can be linked with other libraries (nghttp2 at least) and we > possibly should take care of it to perform static build successfully on Fixed > CURSES_CURSES_LIBRARY is not used. > CURSES_NCURSES_LIBRARY is not used. > CURSES_FORM_LIBRARY is not used. > > I don't get the point of this block (except placing libtinfo.a into deps if > it is present). Please, clarify it or remove the dead code. This variables are used by FindCurses module internally. We could set it to the libraries we want and FindCurses wouldn't locate dynamic versions for that libraries while execution. > > > +if(BUILD_STATIC) > > + # Static linking for c++ routines > > + add_compile_flags("C;CXX" "-static-libgcc" "-static-libstdc++") > > +endif() > > + > Fixed we can't remove libgcc from dynamic dependencies > You are use `generic_libraries` variable for pthread and dl below. Maybe > set the variable above and use it here too? Fixed > Note: Z_LIBRARY is not used below. Fixed, Z_LIBRARY is now OPENSSL_LIBRARIES member > This hunk cannot be applied automatically on top of the current 1.10, > because of adding ${ICONV_LIBRARIES} in dcac64af. Can you please rebase > on top of 1.10? The rest are applied successfully. Fixed > You have ${generic_libraries} added at end of core.a target, but here it is Fixed --nextPart139620925.hoJTvvvH1q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEBJFDbU76LsBbgHBsvKOmCX79zb4FAluGOB8ACgkQvKOmCX79 zb6dXAgAoDVbC/zi/fvc02CLufqI6vwy9CqIAesrfd+rEj3UcL4u0+oDyU02ICtR DZh1M2gyeS8NvvRsa+HJcERHVVulNICvngZ4ZxXS3RI94W3jhBNES0uQv8v00Zd7 wZkcVt/gD2RThVGBZxHlcJzUbf031fja1yB0tkLTrZjobPVCKa3+gOREDnhdYH8U ZLP2kUQ0yWR6wCXLSxnAZb5kG8gJxCQTRXb8PG0ViCp+Sxr30FUDFidIoy5+UVMy rNs7t5PtEcT/2+n/vgCqp1SmWCau9aSao6tT86QF0V3dj+HfmJJL2C6Mqmd8n0AQ 6vjGdWtWYF9uPAPC2oLb19dDyBIgcA== =8kdQ -----END PGP SIGNATURE----- --nextPart139620925.hoJTvvvH1q--