From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A9AF346970E for ; Mon, 20 Jan 2020 22:21:35 +0300 (MSK) From: Georgy Kirichenko Date: Mon, 20 Jan 2020 22:21:34 +0300 Message-ID: <2015073.irdbgypaU6@localhost> In-Reply-To: References: <2144259.ElGaqSPkdT@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart12445410.uLZWGnKmhe"; micalg="pgp-sha256"; protocol="application/pgp-signature" Subject: Re: [Tarantool-patches] [PATCH v2 3/3] box: remove dead code from box_process_call/eval() List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, kostja.osipov@gmail.com, Vladislav Shpilevoy --nextPart12445410.uLZWGnKmhe Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Sunday, 19 January 2020 20:32:45 MSK Vladislav Shpilevoy wrote: > Hi! Thanks for the review! > > On 17/01/2020 18:41, Georgy Kirichenko wrote: > > On Friday, 17 January 2020 00:54:23 MSK Vladislav Shpilevoy wrote: > >> box_process_call/eval() in the end check if there is an > >> active transaction. If there is, it is rolled back, and > >> an error is set. > >> > >> But rollback is not needed anymore, because anyway in > >> the end of the request the fiber is stopped, and its > >> not finished transaction is rolled back. Just setting > >> of the error is enough. > > > > Hi! > > > > Thanks for the patch, but I do not think that to remove an explicit > > rollback> > > is a a good idea because of broken encapsulation - call and eval handlers > > should not rely on its execution context - a simple fiber, iproto fiber > > pool member or whatever else. Also I would like to mention that box_call > > and box_eval are members of the public api and it is not necessary that > > user will stop a fiber. > > Functions box_call and box_eval don't exist. So I don't understand what you > are talking about. > > Assume you talked about box_process_call/eval. In that case you are wrong - > they are not a part of the public API. They are always called from iproto.cc > only. Sorry, you are right, I though we already export them. > Besides, we will need to remove ER_FUNCTION_TX_ACTIVE and all the > other txn stuff from them anyway after interactive transactions are ready. This error should be removed only when we are not in context of a sequence stream of operations. This is not implemented yet so I think we should not change this behavior right now, because I pretty sure we should preserve backward compatibility. --nextPart12445410.uLZWGnKmhe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEECXG+Yw5ArYcP8x5wDVHWG5PoUw4FAl4l/b4ACgkQDVHWG5Po Uw44Xgf+KHryzCrGjexMBfvnOP2sasGtQZ7Rp7DM0rJ0GYIGhDWrktUYRf6qqe7m tBJikz2nMlbJlQ9NkhPrE6/4oOWhCyTovEP/JhMmdGTyd01Du3qJMXjDDt9U7l91 FaH+6f0rhxOM5N7faNw93xx+DFqCZN4YpixQDVg4RiZkkdeo00RV6ZZoppq4MT0y /zo/jjfBIqRcM/Qxfqytw1mGl2AkB2L8N1QiWaijJEy6xLf+z2ib8+ePOffUuHyl YC5Xrgu0GIwY/Rc9oP0RwJ3uyGLDp9HkLefcKdpXi/powaQbhiWAJbW4RXoR8duc m1EQcQgprIecPZS4IPRn6QXkCzAvBg== =20Tk -----END PGP SIGNATURE----- --nextPart12445410.uLZWGnKmhe--