From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CEF402BEE2
	for <tarantool-patches@freelists.org>; Mon, 27 May 2019 17:49:21 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id BXJsKZXCVYbO for <tarantool-patches@freelists.org>;
	Mon, 27 May 2019 17:49:21 -0400 (EDT)
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8FA902BED9
	for <tarantool-patches@freelists.org>; Mon, 27 May 2019 17:49:21 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 3/3] sql: fix passing FP values to
 integer iterator
References: <cover.1558700151.git.korablev@tarantool.org>
 <789091b7acd99c908d26689f27c55f8b6dba3d16.1558700151.git.korablev@tarantool.org>
 <20190525055140.GA14501@atlas>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <1fea92f3-20cc-d539-4010-0ef00b1b6c9a@tarantool.org>
Date: Tue, 28 May 2019 00:49:18 +0300
MIME-Version: 1.0
In-Reply-To: <20190525055140.GA14501@atlas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Konstantin Osipov <kostja@tarantool.org>
Cc: Nikita Pettik <korablev@tarantool.org>



On 25/05/2019 08:51, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [19/05/24 20:42]:
>> That happened due to the fact that type casting mechanism (OP_ApplyType)
>> doesn't affect FP value when it is converted to integer. Hence, FP value
>> was passed to the iterator over integer field which resulted in error.
>> Meanwhile, comparison of integer and FP values is legal in SQL.  To cope
>> with this problem for each equality comparison involving integer field
>> we emit OP_MustBeInt, which checks whether value to be compared is
>> integer or not. If the latter, we assume that result of comparison is
>> always false and continue processing query. 
> 
> Are you sure other vendords would fail to return any results for
> WHERE foo = 1.0?

I do not understand, what you are talking about. It works.

tarantool> box.execute("CREATE TABLE t1(id INT PRIMARY KEY, a INT UNIQUE);")
---
- row_count: 1
...

tarantool> box.execute("INSERT INTO t1 VALUES (1, 1);")
---
- row_count: 1
...

tarantool> box.execute("SELECT a FROM t1 WHERE a = 1.0;")
---
- metadata:
  - name: A
    type: integer
  rows:
  - [1]
...