From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0D1656EC55; Thu, 29 Jul 2021 21:57:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0D1656EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627585051; bh=+8mmZFnbZzG0YL1Y/q+PWtM7B7/Cqr60iGatZCS4/P8=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=G1frVBRatEnCIclVELHbpxku5f3OvNsEeaKfXFCshwynHxMSB5XrfGAFvjd9tAXfi vShJjeyCLr8uC2bruOw9JK5XB+vZQYEUJopIP2mh7KwhBuovgf0rhh/85sEan1eapi H69pmoGNuYxi/+exRa+UI5+DJMYdQOIzq1T1SfKM= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 40E8B6EC5C for ; Thu, 29 Jul 2021 21:56:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 40E8B6EC5C Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1m9BD4-0002kc-ES; Thu, 29 Jul 2021 21:56:46 +0300 To: Timur Safin , v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <2939f293071df83ba612c431895adea49c9cb8de.1627468002.git.tsafin@tarantool.org> Message-ID: <1f485144-efa1-3b19-c283-380908f4975c@tarantool.org> Date: Thu, 29 Jul 2021 21:56:46 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <2939f293071df83ba612c431895adea49c9cb8de.1627468002.git.tsafin@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B21928AAE70459C21B182A05F5380850409E2E85D912635D75D2292D9D2A42FF4D7F4CC12A5FDD218D77FDFCA9A30193C4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE741A8F2705CF52F55EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727BBC20C3D5F36038638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D847CD612E0A4A029A5A011F6D50BE0698117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7B96B19DC4093321B341D7040ADD27A2D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE362B3BD3CC35DA588C0837EA9F3D19764C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637EC3198ECE464ADAEEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79DB53CE84373687089719C67C08280C5DB X-C1DE0DAB: 0D63561A33F958A54169B9D3E2F5B4044CD368319B8D92CF5B67EFAAF3EE0B98D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7536C62C4FBC402878410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FACF503ACC83041BED2CC0427FDCB65CEC05C3B8A5652E39B813D15430C86931C3CF9BD7B17134121D7E09C32AA3244CC88605EB836F70136B9DF15D7DB09E34FE8DA44ABE2443F7FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojPp/mPgZxawHWyE1bWHRCfQ== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6BC9B4598B90D0F426D2292D9D2A42FF4DE5E949923882BAAD7019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD287402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH resend v2 06/11] box, datetime: datetime comparison for indices X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your patch. One question below. Also update with arithmetic operations doesn't work. ``` tarantool> box.space.dt:update({v}, {{'+', 2, 3}}) --- - error: 'Argument type in operation ''+'' on field 2 does not match field type: expected     a number' ... tarantool> box.space.dt:update({v}, {{'+', 2, dt.week(1)}}) --- - error: unsupported Lua type 'cdata' ... ``` On 28.07.2021 13:34, Timur Safin via Tarantool-patches wrote: > * storage hints implemented for datetime_t values; > * proper comparison for indices of datetime type. > > > diff --git a/test/engine/datetime.result b/test/engine/datetime.result > new file mode 100644 > index 000000000..3ff474dee > --- /dev/null > +++ b/test/engine/datetime.result > @@ -0,0 +1,77 @@ > +-- test-run result file version 2 > +env = require('test_run') > + | --- > + | ... > +test_run = env.new() > + | --- > + | ... > +engine = test_run:get_cfg('engine') > + | --- > + | ... > + > +date = require('datetime') > + | --- > + | ... > + > +_ = box.schema.space.create('T', {engine = engine}) > + | --- > + | ... > +_ = box.space.T:create_index('pk', {parts={1,'datetime'}}) > + | --- > + | ... > + > +box.space.T:insert{date('1970-01-01')}\ > +box.space.T:insert{date('1970-01-02')}\ > +box.space.T:insert{date('1970-01-03')}\ > +box.space.T:insert{date('2000-01-01')} > + | --- > + | ... > + > +o = box.space.T:select{} > + | --- > + | ... > +assert(tostring(o[1][1]) == '1970-01-01T00:00Z') > + | --- > + | - true > + | ... > +assert(tostring(o[2][1]) == '1970-01-02T00:00Z') > + | --- > + | - true > + | ... > +assert(tostring(o[3][1]) == '1970-01-03T00:00Z') > + | --- > + | - true > + | ... > +assert(tostring(o[4][1]) == '2000-01-01T00:00Z') > + | --- > + | - true > + | ... > + > +for i = 1,16 do\ > + box.space.T:insert{date.now()}\ > +end > + | --- > + | ... > + > +a = box.space.T:select{} > + | --- > + | ... > +err = nil > + | --- > + | ... > +for i = 1, #a - 1 do\ > + if tostring(a[i][1]) >= tostring(a[i+1][1]) then\ Why do you compare string representation but not values itself? > + err = {a[i][1], a[i+1][1]}\ > + break\ > + end\ > +end > + | --- > + | ... > + > +err > + | --- > + | - null > + | ... > +box.space.T:drop() > + | --- > + | ... >