From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ACE194F62AF; Thu, 13 Jul 2023 14:52:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ACE194F62AF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689249174; bh=y8ZyZRWJRc+ohxphV/z1iWpURFj5y3ZUiL2Rs9JP0bw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=vD7vhJoUnhzTRNl9lAenjiJu2JoeDpYKPE/YdmKtMXZ0keZ1Z0ntrPjUhayTQB+og DEtbl34a7kEI2NqSc7i5rXZmCVBW/2/7CSgAbFaRpSTW4NocABgKHQiQWE8abMuEdh BJT1iQOLYEdDCA6gQ8nIwXSQ2uYNi/xOkUndqF4U= Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [95.163.41.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 64C7E4F62AF for ; Thu, 13 Jul 2023 14:52:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 64C7E4F62AF Received: by smtp34.i.mail.ru with esmtpa (envelope-from ) id 1qJusP-00A2u2-KX; Thu, 13 Jul 2023 14:52:54 +0300 Message-ID: <1f0fb62f-b196-44a0-1e32-4a18efc56e5d@tarantool.org> Date: Thu, 13 Jul 2023 14:52:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9B2A9E02D3479B2E01820269E149F1ED29013C2CAD95D1A59182A05F5380850408CBF15DBF5BBBE17B90518925EAF4471F127A7AEF81649F44669AB0286E218D1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922E451CE6E839B1EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063795AFAF91F541EBCE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AC924256140BC0C55DA5F3B6204EDF9C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FECB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B19735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C30AA277257C6A5E3D76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C22494854413538E1713FE827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5CB5CC3FBCC4957242058D5F3E9879F007B59EC67646AC6BBF87CCE6106E1FC07E67D4AC08A07B9B06A1CB4668A9CA5FACB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF1983EE2D9B01413B77E81A08ABC3FFED0382B909EA0441CC311AA245DE16C0DB8D4FFD5EE5365399399DF444199BC1D1FBA6D24A7392238CB7DB83E60363300EE48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmIyQFW4pVcl3rIYyh6A3kQ== X-Mailru-Sender: 49D287FBCBBF3A5C1746B9497B71E89E6192BF56C187BAD6B90518925EAF44718FF8BC079CCEBBDCEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] build: introduce LUAJIT_USE_ASAN option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! This patch LGTM after fixing a typo. Sergey On 7/13/23 00:09, Igor Munkin wrote: > There was nether a special option nor a variable to configure the Typo: nether -> neither > sanitizers support via the build system since the commit > 052c1a32a5e74b337686eee229d089d576775931 ("Add preliminary ASAN > support") where ASan support had been introduced. We finally decided to > use this feature in LuaJIT CI, so for convenient build configuration > LUAJIT_USE_ASAN option is added to the root CMakeLists.txt. > > Resolves tarantool/tarantool#5878 > > Co-authored-by: Sergey Kaplun > Signed-off-by: Igor Munkin > --- > CMakeLists.txt | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 6ef24bba..f113a53d 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -269,15 +269,13 @@ if(LUA_USE_ASSERT) > AppendFlags(TARGET_C_FLAGS -DLUA_USE_ASSERT) > endif() > > -# TODO: Implement a configuration option to enable ASAN. > -# There are two entries of LUAJIT_USE_ASAN define: > -# $ grep -rnF 'LUAJIT_USE_ASAN' . > -# ./src/lj_str.c:15:#if LUAJIT_USE_ASAN > -# ./src/host/buildvm.c:36:#if LUAJIT_USE_ASAN > -# At the same time this flag is not provided by LuaJIT original > -# build system (i.e. src/Makefile.original) so there are no > -# related compiler and linker flags passed. This should be done > -# the right way later. > +# Turn on AddressSanitizer support. As a result, all artefacts > +# (i.e. buildvm, LuaJIT, testing infrastructure) are built with > +# ASan enabled. > +option(LUAJIT_USE_ASAN "Build LuaJIT with AddressSanitizer" OFF) > +if(LUAJIT_USE_ASAN) > + AppendFlags(CMAKE_C_FLAGS -DLUAJIT_USE_ASAN -fsanitize=address) > +endif() > > # --- Main source tree --------------------------------------------------------- >