From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9CEEA6FC8F; Wed, 6 Oct 2021 00:56:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9CEEA6FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1633470971; bh=Edy81X5xTjjGW0HojZ/7NCyaDZxVGN0UXeD56AYp/g0=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lSMgt9h+1vG7gofqqPNUBONxpBaWddVihfl7qPoMKWKsDbcESTGTnaQPbx9bT7mG+ aML6iTlWBqXkm+0EMt6AshO+hoJqphTDhdCcflUQS7laks+X6/39IOc4SJBAPG7Inr Xb7a+gJVCDRuoZvwwIBjU2TYKvcIDRlNF0HvN44k= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B2C056FC8F for ; Wed, 6 Oct 2021 00:56:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2C056FC8F Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mXsPy-0004e7-1p; Wed, 06 Oct 2021 00:56:10 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <1e9ce07c-8615-0802-3ddf-757b5d55774f@tarantool.org> Date: Tue, 5 Oct 2021 23:56:08 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD95441136EB4F02491C5AAC6281DF12AFA8B76770212013A0A182A05F53808504046488C239ACAEDCA2D97A506DB3E14B0E5879C68EFC8CAC63A96C1B09C27C6FB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70ED3881ADD6CEF6AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376F127A835590024F8F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB5533756680CE368667DD8FDE8B72EEEE3C56C70D85DD5CCEF2965DEAA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34964A708C60C975A117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637C970FD8DF19C51D2EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505D05C3414A862E45000FFD723A89EB671 X-C1DE0DAB: 0D63561A33F958A596621D02461A0AF7BCA5D6DA11FD830D3EAF399613745113D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75C4D20244F7083972410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34128DEC38EFF4BE5A3E5CEB575D934B90CFC716C84646117FE718773C694569F957B85FA07BEBED5D1D7E09C32AA3244CB44E2E7BFFC9E02E0EB88D00054003148894E9C85370243E729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhAh8SZXECpBYqxb0kEA3YA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D4C10A5E6F335E7567E3AD949A1952ABC3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/3] sql: fix truncation of DECIMAL in implicit cast X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patchset! > diff --git a/test/sql-tap/gh-6485-bugs-in-decimal.test.lua b/test/sql-tap/gh-6485-bugs-in-decimal.test.lua > new file mode 100755 > index 000000000..3f63f2b76 > --- /dev/null > +++ b/test/sql-tap/gh-6485-bugs-in-decimal.test.lua > @@ -0,0 +1,16 @@ > +#!/usr/bin/env tarantool > +local test = require("sqltester") > +test:plan(1) > + > +-- Make sure DECIMAL is not truncated when used in an index. > +test:do_execsql_test( > + "gh-6485-1", > + [[ > + CREATE TABLE t(i INTEGER PRIMARY KEY); > + INSERT INTO t VALUES(1), (2); > + SELECT i FROM t WHERE i IN (CAST(1.1 AS DECIMAL), CAST(2.2 AS DECIMAL)); > + DROP TABLE t; > + ]], { Could you make the same select without creating a table? The same for the tests in the second commit. Also you might want to make the test run only once. Now it is run twice with 2 engines.