From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 22B4AE86BFA; Fri, 20 Dec 2024 15:31:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 22B4AE86BFA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1734697917; bh=xgSXZNqt2r9PkAUWeagxfYk3jH1kA/+Jr18Ovm123aE=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=cUSoi0EkO2XqiBoqgQvdXKXA0/3llm9/hdV0FgKNxpIDe0MLbzGoyYceHC7Wf4BGP 1DOrScaEJuLxtm16mL6Tu3ZycOiB7n3Q2FF4Gx8eKR+RFPECJgNibTGhHjeODTOyx0 evqnzI/WyJ0/swXOCmxrPueHaU/bIdPnRGnhPc80= Received: from send218.i.mail.ru (send218.i.mail.ru [95.163.59.57]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E56C9E86BFA for ; Fri, 20 Dec 2024 15:31:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E56C9E86BFA Received: by exim-smtp-cc4f974bf-j2556 with esmtpa (envelope-from ) id 1tOcAc-00000000BwY-3cvD; Fri, 20 Dec 2024 15:31:55 +0300 Content-Type: multipart/alternative; boundary="------------s20mC9bFKfhhFRMugNuiguRb" Message-ID: <1d75a7de-f58a-42c5-ad17-61170e66de2b@tarantool.org> Date: Fri, 20 Dec 2024 15:31:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <20241219131116.27586-1-skaplun@tarantool.org> In-Reply-To: <20241219131116.27586-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD90D1D1AB545089981E45019BE5F1587EE0EB21171BC1D3325182A05F538085040F4E9A27C484854993DE06ABAFEAF6705FA1E456859692D529CAB118109082E81A9248E35AFBCB78E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73C714006C69EB7BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063700ADE00200597A808638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D806DF781A728D8CCBBC2C2FC0DF309DA4811A82812B4351DCCC7F00164DA146DAFE8445B8C89999728AA50765F7900637BA939FD1B3BAB99B389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8989FD0BDF65E50FBF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C1DAA61796BF5227B6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C376D908F7383ECAB2BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7AEF083857ED04614731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A594854CD93DAD606E5002B1117B3ED69641D9DBB6E07B65F43E67C18142C611B7823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF00A863F61124E00A1A441E9EA85639507D9FB1610EB44CA67932EEF576615149327C9FD717F3371824A398DE2C7926ED05E75591D66CDC7C126F70F89780CAC5C525562CE11F741E5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojfZ9BPZgVRhrGcKae+4in+Q== X-Mailru-Sender: 0A26D9779F8DDEABFCA39D68568FDFDBC8D2D0813DA958F97FC47A557B39A39B8802C1B05C3E6E1D90AF6EAF49565B85645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix flaky fix-slots-overflow-for-varg-record X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------s20mC9bFKfhhFRMugNuiguRb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM On 19.12.2024 16:11, Sergey Kaplun wrote: > The aforementioned test is flaky when it is run by Tarantool, since the > necessary trace isn't compiled due to hotcount collisions. This patch > fixes this by adding the additional reset of hot counters. > --- > > Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-flaky-test > > Tested locally on the Tarantool > Before the patch: > | ctest --repeat-until-fail 100 -R fix-slots-overflow-for-varg-record.test.lua > Failed > > With the patch > | ctest --repeat-until-fail 1000 -R fix-slots-overflow-for-varg-record.test.lua > |... > | 100% tests passed, 0 tests failed out of 1 > > .../fix-slots-overflow-for-varg-record.test.lua | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua > index b09a722d..7ffa6719 100644 > --- a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua > +++ b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua > @@ -89,6 +89,9 @@ wrapper() > > assert(not traceinfo(1), 'no traces recorded') > > +-- Reset hot counters to avoid collisions and blacklisting. > +jit.opt.start('hotloop=1') > + > -- The simplest trace to compile. > for _ = 1, 4 do end > --------------s20mC9bFKfhhFRMugNuiguRb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM

On 19.12.2024 16:11, Sergey Kaplun wrote:
The aforementioned test is flaky when it is run by Tarantool, since the
necessary trace isn't compiled due to hotcount collisions. This patch
fixes this by adding the additional reset of hot counters.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-flaky-test

Tested locally on the Tarantool
Before the patch:
| ctest --repeat-until-fail 100 -R fix-slots-overflow-for-varg-record.test.lua
Failed

With the patch
| ctest --repeat-until-fail 1000 -R fix-slots-overflow-for-varg-record.test.lua
|...
| 100% tests passed, 0 tests failed out of 1

 .../fix-slots-overflow-for-varg-record.test.lua                | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua
index b09a722d..7ffa6719 100644
--- a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua
+++ b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua
@@ -89,6 +89,9 @@ wrapper()
 
 assert(not traceinfo(1), 'no traces recorded')
 
+-- Reset hot counters to avoid collisions and blacklisting.
+jit.opt.start('hotloop=1')
+
 -- The simplest trace to compile.
 for _ = 1, 4 do end
--------------s20mC9bFKfhhFRMugNuiguRb--