Hi, Sergey,
thanks for the patch! LGTM
The aforementioned test is flaky when it is run by Tarantool, since the necessary trace isn't compiled due to hotcount collisions. This patch fixes this by adding the additional reset of hot counters. --- Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-flaky-test Tested locally on the Tarantool Before the patch: | ctest --repeat-until-fail 100 -R fix-slots-overflow-for-varg-record.test.lua Failed With the patch | ctest --repeat-until-fail 1000 -R fix-slots-overflow-for-varg-record.test.lua |... | 100% tests passed, 0 tests failed out of 1 .../fix-slots-overflow-for-varg-record.test.lua | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua index b09a722d..7ffa6719 100644 --- a/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua +++ b/test/tarantool-tests/fix-slots-overflow-for-varg-record.test.lua @@ -89,6 +89,9 @@ wrapper() assert(not traceinfo(1), 'no traces recorded') +-- Reset hot counters to avoid collisions and blacklisting. +jit.opt.start('hotloop=1') + -- The simplest trace to compile. for _ = 1, 4 do end