From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D8E0653D8B9; Mon, 24 Jul 2023 13:37:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D8E0653D8B9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1690195023; bh=85qccVWq2ZpbvV3qVmOJDCZ1DJhdEwLDDOdCQHDoz4E=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=G6wA+fSDipTD/pRs81HBqVL9+OTRdUyS2yeqx10YPYo0HrBuvO+GSQnl+9FoxmXE8 5FUMmEIvlmnP2t4b2jyH8auaT8ufTd0YL9vKLkf7nyYxnZWdj3lFZyfQG12F4OiDaE 5iUDkdOTQjZirp2FJFAZWUEdZiZpAWUcs2vgMyOg= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [95.163.41.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 829BE4BF2ED for ; Mon, 24 Jul 2023 13:37:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 829BE4BF2ED Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1qNsw0-006v7y-L2; Mon, 24 Jul 2023 13:37:01 +0300 Message-ID: <1d4fcef0-b238-b435-27b1-44699db444a0@tarantool.org> Date: Mon, 24 Jul 2023 13:36:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9227D43F3CB451B41C680B045355580F9F91DE19E33172CA4182A05F53808504087D756EA7B0730EF92E88957B4D9C6956DECB4DA1F30C91046ED5E2F12B270FD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063753275FB77F6A31628638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DF17E3A457A13E91B00CFA0A4F8626FF117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BDCBA8CBAA3833548A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC75B7A1B89F33CEE13AA81AA40904B5D9CF19DD082D7633A0C84D3B47A649675F3AA81AA40904B5D98AA50765F79006374831FD27DAE3AC17D81D268191BDAD3D3666184CF4C3C14F3FC91FA280E0CE3D1A620F70A64A45A98AA50765F7900637CD149F92CBFD81166D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637F765F39FA4E70FFE43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A597997C0CE0BE5BF957F6854F9BD1FF28BE071752DCC3DC05F87CCE6106E1FC07E67D4AC08A07B9B082B967D547A19D2FCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFBEB5331D686ADA3D35FE94671D045DF7BB126B960CAC86BFFE1A696D8F1B819CB469278E65BD125AC81315DA36159FFBB2105F1339C923DC6DB0D858142838ABE48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojHVt7enifY/vJDmrr8mf6OQ== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769024947DCBE1AF63792E88957B4D9C69541B07CD4FDF173FBEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/5] ci: clean up workflow for exotic builds X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! LGTM On 7/21/23 11:12, Igor Munkin wrote: > Unfortunately, the same mistake, that was introduced in the very first > commit f877b7691d9eae73d64c63ee3770089569915459 ("ci: introduce GitHub > Actions") and was fixed in the main testing pipeline in scope of the > commit 524616a35c1267cb9ca260b8456b71dde1881e22 ("ci: remove GC64 matrix > entries for ARM64 workflows"), was made in the new CI pipeline added in > scope of the commit 32ac0cadcba58cd69058084c88100fdcc7b7dccf ("ci: add > ARM64 architecture to exotic testing"). > > Specifically, CMake option LUAJIT_ENABLE_GC64 changes nothing for ARM64 > LuaJIT builds (i.e. LJ_GC64 is defined on ARM64 platforms despite the > value of LUAJIT_ENABLE_GC64). As a result GC64 entry is removed from > all ARM64 flavors in exotic builds testing routine. > > Besides, all flavor labels are sorted alphabetically. > > Signed-off-by: Igor Munkin > --- > .github/workflows/exotic-builds-testing.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml > index 318fb4dd..7c57d238 100644 > --- a/.github/workflows/exotic-builds-testing.yml > +++ b/.github/workflows/exotic-builds-testing.yml > @@ -34,7 +34,7 @@ jobs: > BUILDTYPE: [Debug, Release] > ARCH: [ARM64, x86_64] > GC64: [ON, OFF] > - FLAVOR: [dualnum, checkhook, nojit, gdbjit] > + FLAVOR: [checkhook, dualnum, gdbjit, nojit] > include: > - BUILDTYPE: Debug > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > @@ -49,6 +49,8 @@ jobs: > - FLAVOR: gdbjit > FLAVORFLAGS: -DLUAJIT_USE_GDBJIT=ON > exclude: > + - ARCH: ARM64 > + GC64: OFF > # DUALNUM is default for ARM64, no need for additional testing. > - FLAVOR: dualnum > ARCH: ARM64