From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1885653D9EF; Thu, 20 Jul 2023 21:14:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1885653D9EF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689876876; bh=0z/rz5CeKgMRSxQuAwGhZlGTku8R20nOqwTBQvywD3E=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MYDpfX+5f0uxELxxywy2j5odqdNxSFFpEwdJ9iwLxZew1kOlysSgmPuoG3qFfUzX2 750Sa7pGoptXOxQl8MQbA/QgQUyyotAspIbYzMJKQviQEZW8uXSBxPrOvRCd1icnGD 9s4lzi+r6W0ZbutZsr+z7tGVUXeoyxNewLLJtGaI= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [95.163.41.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2DB6953D9EF for ; Thu, 20 Jul 2023 21:14:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2DB6953D9EF Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1qMYAc-002Wrf-C9; Thu, 20 Jul 2023 21:14:34 +0300 Content-Type: multipart/alternative; boundary="------------MldfIJkk3YPw3BZ3yffDCNST" Message-ID: <1cc3d336-782c-64ea-95fe-388360d4ea6a@tarantool.org> Date: Thu, 20 Jul 2023 21:14:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Maxim Kokryashkin , Sergey Bronnikov Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org References: <28d01b012c35749e8087ee21326e275c5bba6a21.1689600525.git.sergeyb@tarantool.org> <1689619710.740225619@f193.i.mail.ru> In-Reply-To: <1689619710.740225619@f193.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9227D43F3CB451B41616FC75AC98AB10873760FAF3730B0E5182A05F538085040E3F59E1F0B7112ABA1C81F3926693057D85438CB7C0049B9162A5954C117EB2A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE701173C01F417A2A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BC4B0F5721B555078638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C5706AE8757119E11CE07CC98CA7E2F1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BDCBA8CBAA3833548A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FCD5E8704C5CAD72113AA81AA40904B5D9CF19DD082D7633A0C84D3B47A649675F3AA81AA40904B5D98AA50765F790063734E399CB81F16120D81D268191BDAD3D3666184CF4C3C14F3FC91FA280E0CE3D1A620F70A64A45A98AA50765F7900637A451E1E29F2EDBED6D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637F765F39FA4E70FFE43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5FF749CE33E6365EABADEB17EFF7EBDB04C5C931443CAC120F87CCE6106E1FC07E67D4AC08A07B9B0A6C7FFFE744CA7FBCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF7A505DA0C1931649EAE5FFCE5954B2682F66459E5EABC63B9B34D67FEA96F5FEF85183ADB301C8A87A512D943FCE53BF5D3F50E0948026ABF117D0331ADC4337A74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGEBeBQ0LqGZT6kxEMiBHiA== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458DA6E5B78954429233B0EDC28B96C07C9DCB446A2E3813EC5282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 4/4][v2] ci: enable checkpatch X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------MldfIJkk3YPw3BZ3yffDCNST Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Max! thanks for your review! On 7/17/23 21:48, Maxim Kokryashkin via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the patch! > Please consider my comments below. > > From: Sergey Bronnikov > > > Patch enables running checkpatch [1] for checking patch on a > pre-commit > > The pre-commit stage makes no sense when we are talking about CI — the > commit has already occurred. That’s just a conventional workflow > configuration. > In my mind "pre-commit" means commit to a target branch, in our case it is a "tarantool/master". > > Having that in mind, along with some grammar related issues. I suggest > rephrasing it like: > | Patch adds a CI workflow with the checkpatch[1] run. > Updated. > > stage. > > 1. https://github.com/tarantool/checkpatch > --- >  .github/actions/checkpatch/action.yml | 11 +++++++++++ >  .github/workflows/lint.yml | 20 ++++++++++++++++++++ >  2 files changed, 31 insertions(+) >  create mode 100644 .github/actions/checkpatch/action.yml > > diff --git a/.github/actions/checkpatch/action.yml > b/.github/actions/checkpatch/action.yml > new file mode 100644 > index 00000000..2336fb15 > --- /dev/null > +++ b/.github/actions/checkpatch/action.yml > @@ -0,0 +1,11 @@ > +name: Checkpatch > +description: Check patches against LuaJIT development guidelines > > I think it’s better to change the action name to `Setup checkpatch`, > since the actual run is not performed here. > The description should be updated correspondingly. Also, AFAIK, there > is no such thing as `LuaJIT guidelines`, so maybe it’s better to > change it > to `Tarantool guidelines` if you want to keep that part. > Updated. --------------MldfIJkk3YPw3BZ3yffDCNST Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Max!

thanks for your review!


On 7/17/23 21:48, Maxim Kokryashkin via Tarantool-patches wrote:
Hi, Sergey!
Thanks for the patch!
Please consider my comments below.
 
 
From: Sergey Bronnikov <sergeyb@tarantool.org>

Patch enables running checkpatch [1] for checking patch on a pre-commit
The pre-commit stage makes no sense when we are talking about CI — the
commit has already occurred. That’s just a conventional workflow configuration.
 
In my mind "pre-commit" means commit to a target branch, in our case it is a "tarantool/master".
Having that in mind, along with some grammar related issues. I suggest
rephrasing it like:
| Patch adds a CI workflow with the checkpatch[1] run.
Updated.
stage.

1. https://github.com/tarantool/checkpatch
---
 .github/actions/checkpatch/action.yml | 11 +++++++++++
 .github/workflows/lint.yml | 20 ++++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 .github/actions/checkpatch/action.yml

diff --git a/.github/actions/checkpatch/action.yml b/.github/actions/checkpatch/action.yml
new file mode 100644
index 00000000..2336fb15
--- /dev/null
+++ b/.github/actions/checkpatch/action.yml
@@ -0,0 +1,11 @@
+name: Checkpatch
+description: Check patches against LuaJIT development guidelines
I think it’s better to change the action name to `Setup checkpatch`,
since the actual run is not performed here.
The description should be updated correspondingly. Also, AFAIK, there
is no such thing as `LuaJIT guidelines`, so maybe it’s better to change it
to `Tarantool guidelines` if you want to keep that part.
Updated.


<snipped>

 
--------------MldfIJkk3YPw3BZ3yffDCNST--