From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9279A16599DE; Tue, 23 Dec 2025 13:37:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9279A16599DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1766486277; bh=gdTNyt+ce03TPPSPUsYJ0nOZ52RWXrp1ytpJ5xLrYUk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=IXq+EFFDOjxUKy4TeJsEnu0cjitWFelD74/MrjCKW4U4BZjfHToXHvBqw95ZhFrl8 aZ1+GnqB4MQFG44QP23RfhVg72u8nWBW4ax531+D8W+EUKxpjzGN31p2j7WO6p+qrH jPzgzbNE4/u9SbPVWHXYDwu7s6EtmnD1b/Jp8xhg= Received: from send149.i.mail.ru (send149.i.mail.ru [89.221.237.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DE3AA54EB90 for ; Tue, 23 Dec 2025 13:37:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DE3AA54EB90 Received: by exim-smtp-7b4fb89df9-f7qdb with esmtpa (envelope-from ) id 1vXzm6-0000000046l-3BEC; Tue, 23 Dec 2025 13:37:55 +0300 Content-Type: multipart/alternative; boundary="------------d2DaFlf0BbkkM5P0b8ZuCB3o" Message-ID: <1c8f6721-5ea9-4f40-8f33-f2dbf1c56782@tarantool.org> Date: Tue, 23 Dec 2025 13:37:54 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <5fb7539d5539b29ed416c83a3ec413c5032c99ab.1761301736.git.skaplun@tarantool.org> In-Reply-To: <5fb7539d5539b29ed416c83a3ec413c5032c99ab.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9169BA2A4A1D10D000E5C875BB2B03780DBEA03B93A33108F182A05F5380850401E22FAEA7FD42A013DE06ABAFEAF670518A4202776414BA46DBB412B9F8581CA23B53866B3CF53F4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78981306C6E927004EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F28F4AF03526AA8F8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B293CE675C7C75962C2E070BE324C7D3C427B1845617194657F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22494854413538E1713FCC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0B2508BF041A7935C7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1A9539A8B24243104B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BBD04F29638EDF8E275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A583E2346781A8CA995002B1117B3ED696B31723A23318114930C8F815570A3530823CB91A9FED034534781492E4B8EEADA91A6E18C88C5E2F X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6599F3CA7FCCCF61B9271B5FDD471208F669C9BCED487A5B227537D5C3CCFBECA8A864D9EFA9F687A58B8341EE9D5BE9A0A4E5E00D2E4FCAF3705CB097BA505BE421473C97ED2E09CD18CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVdtTL5f5BIXbDMCDIqCYiUA= X-Mailru-Sender: 811C44EDE0507D1FFB106D83BFFB684FBE88B6E9B9051C665E07F309F87FFB14742B4F76411765DEE436CDC11A29B020645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 36/41] perf: adjust sum-file in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------d2DaFlf0BbkkM5P0b8ZuCB3o Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM Sergey On 10/24/25 14:00, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > The input for the test is redirected from the generated file > . This file is the result of concatenation of the > 5000 times. > --- > perf/LuaJIT-benches/sum-file.lua | 29 ++++++++++++++++++++++++----- > 1 file changed, 24 insertions(+), 5 deletions(-) > > diff --git a/perf/LuaJIT-benches/sum-file.lua b/perf/LuaJIT-benches/sum-file.lua > index c9e618fd..270c1865 100644 > --- a/perf/LuaJIT-benches/sum-file.lua > +++ b/perf/LuaJIT-benches/sum-file.lua > @@ -1,6 +1,25 @@ > +local bench = require("bench").new(arg) > > -local sum = 0 > -for line in io.lines() do > - sum = sum + line > -end > -io.write(sum, "\n") > +-- XXX: The input file is generated from by > +-- repeating it 5000 times. The contains 1000 lines > +-- with the total sum of 500. > +bench:add({ > + name = "sum_file", > + payload = function() > + local sum = 0 > + for line in io.lines() do > + sum = sum + line > + end > + -- Allow several iterations. > +io.stdin:seek("set", 0) > + return sum > + end, > + checker = function(res) > + -- Precomputed result. > + return res == 2500000 > + end, > + -- Fixed size of the file. > + items = 5e6, > +}) > + > +bench:run_and_report() --------------d2DaFlf0BbkkM5P0b8ZuCB3o Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM

Sergey

On 10/24/25 14:00, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

The input for the test is redirected from the generated file
<SUMCOL_5000.txt>. This file is the result of concatenation of the
<SUMCOL_1.txt> 5000 times.
---
 perf/LuaJIT-benches/sum-file.lua | 29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

diff --git a/perf/LuaJIT-benches/sum-file.lua b/perf/LuaJIT-benches/sum-file.lua
index c9e618fd..270c1865 100644
--- a/perf/LuaJIT-benches/sum-file.lua
+++ b/perf/LuaJIT-benches/sum-file.lua
@@ -1,6 +1,25 @@
+local bench = require("bench").new(arg)
 
-local sum = 0
-for line in io.lines() do
-  sum = sum + line
-end
-io.write(sum, "\n")
+-- XXX: The input file is generated from <SUMCOL_1.txt> by
+-- repeating it 5000 times. The <SUMCOL_1.txt> contains 1000 lines
+-- with the total sum of 500.
+bench:add({
+  name = "sum_file",
+  payload = function()
+    local sum = 0
+    for line in io.lines() do
+      sum = sum + line
+    end
+    -- Allow several iterations.
+    io.stdin:seek("set", 0)
+    return sum
+  end,
+  checker = function(res)
+    -- Precomputed result.
+    return res == 2500000
+  end,
+  -- Fixed size of the file.
+  items = 5e6,
+})
+
+bench:run_and_report()
--------------d2DaFlf0BbkkM5P0b8ZuCB3o--