From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp15.mail.ru (smtp15.mail.ru [94.100.176.133])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2EA87445320
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 21 Jul 2020 23:26:23 +0300 (MSK)
References: <917bd68fb91e1d113c65a2c74013371f379243a5.1595279482.git.v.shpilevoy@tarantool.org>
 <20200720220931.GB4221@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <1c34a786-93be-1f39-cd31-6bc4504cf428@tarantool.org>
Date: Tue, 21 Jul 2020 22:26:21 +0200
MIME-Version: 1.0
In-Reply-To: <20200720220931.GB4221@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn_limbo: use fiber_clock()
	instead of fiber_time()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Pushed to master.

On 21.07.2020 00:09, Cyrill Gorcunov wrote:
> On Mon, Jul 20, 2020 at 11:11:39PM +0200, Vladislav Shpilevoy wrote:
>> box.ctl.clear_synchro_queue() used fiber_time()
>> instead of fiber_clock() to wait for a timeout. This is wrong,
>> fiber_time() is realtime, not suitable for relative timeouts.
>>
>> For that purpose always should be used monotonic clock. The patch
>> fixes that.
>>
>> Follow up #4849
> 
> (side note: monotonic clocks do not account acpi-deep-sleep state,
>  ie when cpu is in sleep state it wont be accounted, but i think
>  it is impossible scenario for us. so put this note just for
>  reference).
> 
> Good catch!

Thanks for Leonid, he found the problem.

> Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>

Sorry, I forgot to add Acked-By, realized this after push.