From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsafin@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EE6B04696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 17 Apr 2020 10:27:21 +0300 (MSK)
From: "Timur Safin" <tsafin@tarantool.org>
References: <20200413041105.22576-1-roman.habibov@tarantool.org>
 <20200415194149.GA454@tarantool.org>
 <43EE02FF-1F00-4FBE-AC41-C8C58B390003@tarantool.org>
 <20200416081731.GA16144@tarantool.org>
 <6CC4ABB2-D49D-4721-B913-B999D70844FB@tarantool.org>
 <20200417063512.GA10928@tarantool.org>
In-Reply-To: <20200417063512.GA10928@tarantool.org>
Date: Fri, 17 Apr 2020 10:27:20 +0300
Message-ID: <1c1301d61489$a1af1790$e50d46b0$@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH] sql: fix number and boolean sorting
	rules
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: 'Mergen Imeev' <imeevma@tarantool.org>, 'Roman Khabibov' <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

As a random bypasser I could not resist and not add my 5 kopecks (see =
below).

: -----Original Message-----
: From: Mergen Imeev <imeevma@tarantool.org>
:=20
: Hi! Thank you for the fixes. I think that the your
: commit-message and comments sounds quite strange, but I am
: not sure that I am qualified enough to say that for sure.
: Please, send this patch to NIkita. Other than that, LGTM.
:=20


: > commit 8a2133d84b88a050181d858d6109abf3635a121b (HEAD ->
: romanhabibov/gh-4697-scalar-bug, =
origin/romanhabibov/gh-4697-scalar-bug)
: > Author: Roman Khabibov <roman.habibov@tarantool.org>
: > Date:   Mon Apr 13 05:03:54 2020 +0300
: >
: >     sql: fix number and boolean SCALAR sorting rules
: >
: >     Make comparison SCALAR rules in the sql sorter correct for =
number
: >     and boolean. Boolean should always follow before any number.
: >
: >     Closes #4697
: >

Agreed with Mergen that message is confusing, I'd suggest to do this =
simple replacement to make it clearer=20

s/follow before/precede/g

Regards,
Timur