From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roman.habibov@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4F897469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  4 Nov 2020 18:14:33 +0300 (MSK)
References: <20201008215956.93983-1-roman.habibov@tarantool.org>
 <ef8887a7-786a-1c1f-a151-1cf6ee503ba1@tarantool.org>
From: roman <roman.habibov@tarantool.org>
Message-ID: <1bcad83c-d22e-066c-fde9-77d88ac3cd12@tarantool.org>
Date: Tue, 3 Nov 2020 13:01:19 +0300
MIME-Version: 1.0
In-Reply-To: <ef8887a7-786a-1c1f-a151-1cf6ee503ba1@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [Tarantool-patches] [PATCH 0/2] Improve json error message.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Leonid Vasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!
On 12.10.2020 11:51, Leonid Vasiliev wrote:
> Hi! Thank you for the patch.
> Add @ChangeLog.
>
> On 09.10.2020 00:59, Roman Khabibov wrote:
>> I already have LGTM from Vlad.
>>
>> Branch: 
>> https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4339-json-err
>> Issue: https://github.com/tarantool/tarantool/issues/4339
>>
>> Roman Khabibov (2):
>>    json: make error messages more readable
>>    json: print context in error mesages
>>
>>   test/app-tap/json.test.lua        | 50 +++++++++++++++-
>>   third_party/lua-cjson/lua_cjson.c | 97 +++++++++++++++++++++++--------
>>   2 files changed, 122 insertions(+), 25 deletions(-)
>>
@ChangeLog:
* Print json tokens themselves instead of token names "T_*" in the error 
messages (gh-4339).
* Print context in json error mesages (gh-4339).