From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 29FB82811E
	for <tarantool-patches@freelists.org>; Thu,  7 Mar 2019 09:40:26 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id LUWsohyBAIui for <tarantool-patches@freelists.org>;
	Thu,  7 Mar 2019 09:40:26 -0500 (EST)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6CBE624216
	for <tarantool-patches@freelists.org>; Thu,  7 Mar 2019 09:40:25 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH 0/2] Add collation to built-in funcs
 and fix HAVING clause with aggregate
References: <cover.1550768589.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <1b0173d6-42cd-bfc4-4b27-53ba08d3ebbd@tarantool.org>
Date: Thu, 7 Mar 2019 17:40:22 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1550768589.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: Nikita Pettik <korablev@tarantool.org>, tarantool-patches@freelists.org, Kirill Yukhin <kyukhin@tarantool.org>

LGTM.

On 21/02/2019 21:01, Nikita Pettik wrote:
> Issue #3932 consists of two independent bugs. Current patch-set
> provides fixes for both of them.
> 
> Branch: https://github.com/tarantool/tarantool/tree/np/gh-3932-function-collation
> Issue: https://github.com/tarantool/tarantool/issues/3932
> 
> Nikita Pettik (2):
>    sql: derive collation for built-in functions
>    sql: fix code generation for aggregate in HAVING clause
> 
>   src/box/sql/analyze.c         |  6 +++---
>   src/box/sql/expr.c            | 23 +++++++++++++++++++++++
>   src/box/sql/func.c            | 22 +++++++++++-----------
>   src/box/sql/resolve.c         | 10 +++++++---
>   src/box/sql/sqlInt.h          | 31 +++++++++++++++++++++++--------
>   test/sql-tap/select5.test.lua | 25 ++++++++++++++++++++++++-
>   test/sql/collation.result     | 28 ++++++++++++++++++++++++++++
>   test/sql/collation.test.lua   | 11 +++++++++++
>   8 files changed, 130 insertions(+), 26 deletions(-)
> 
> -- 
> 2.15.1
>