From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6033F28527 for ; Fri, 9 Aug 2019 16:56:52 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LdRWDhr6LnIn for ; Fri, 9 Aug 2019 16:56:52 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BD534284FC for ; Fri, 9 Aug 2019 16:56:51 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/3] txn: move fk_deferred_count from psql_txn to txn References: From: Vladislav Shpilevoy Message-ID: <1a4473c8-c4c7-faf4-3c27-54fd77a2532f@tarantool.org> Date: Fri, 9 Aug 2019 22:59:23 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik Hi! Thanks for the patch! > diff --git a/src/box/txn.h b/src/box/txn.h > index 37d90932b..87e880a6a 100644 > --- a/src/box/txn.h > +++ b/src/box/txn.h > @@ -213,6 +208,7 @@ struct txn { > struct trigger fiber_on_stop; > /** Commit and rollback triggers. */ > struct rlist on_commit, on_rollback; > + uint32_t fk_deferred_count; Please, add a comment. A detailed one. That this number is used by SQL only, what does it mean 'deferred fk', why is it stored in the transaction. > struct sql_txn *psql_txn; > }; > >