From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ABD71469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 25 Feb 2020 23:29:24 +0300 (MSK)
References: <1581359737.397395198@f221.i.mail.ru>
 <1582130253.193228635@f540.i.mail.ru> <20200219171602.GB40100@tarantool.org>
 <1582628891.457674764@f461.i.mail.ru> <20200225130257.GA12687@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <1a3127f4-df43-2e45-7045-64b7bfd395b1@tarantool.org>
Date: Tue, 25 Feb 2020 21:29:22 +0100
MIME-Version: 1.0
In-Reply-To: <20200225130257.GA12687@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH] box: sql prepare and execute
 statistics should be reflected in box.stat()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>, Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches <tarantool-patches@dev.tarantool.org>

LGTM as well.

On 25/02/2020 14:02, Nikita Pettik wrote:
> On 25 Feb 14:08, Maria Khaydich wrote:
>>
>> Thanks for the review, all done:
>> ----------------------------------------------------------------------
>> Calling prepare and execute did not update corresponding request statistics
>> in the box.stat table. This happened because methods that collect stats were
>> never called where they should have been.
>>  
>> Closes #4756
>> ---
>> Issue:
>> https://github.com/tarantool/tarantool/issues/4756  
>> Branch:
>> https://github.com/tarantool/tarantool/compare/eljashm/gh-4756-box-stat-execute-and-prepare-not-updated  
>>  
>> @ChangeLog
>> - Fixed box.stat behavior - now it collects statistics on
>>     prepare and execute methods as it should.
>>     gh-4756
> 
> LGTM. Vlad, is patch OK with you? If so, I will push it to master, 2.3 and
> partially (only part related to EXECUTE statistics) to 2.2.
>