From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CABEC26140 for ; Thu, 21 Jun 2018 08:54:25 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lrM_iixjmn0C for ; Thu, 21 Jun 2018 08:54:25 -0400 (EDT) Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 89F3925F4E for ; Thu, 21 Jun 2018 08:54:25 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/2] Preserve route_map on router.cfg References: <344d2c601d489836268d55e0f9207f2a6a577f81.1529066485.git.avkhatskevich@tarantool.org> From: Vladislav Shpilevoy Message-ID: <1a1b796e-0253-0ad4-fb47-7f8ae6aa28b0@tarantool.org> Date: Thu, 21 Jun 2018 15:54:22 +0300 MIME-Version: 1.0 In-Reply-To: <344d2c601d489836268d55e0f9207f2a6a577f81.1529066485.git.avkhatskevich@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, AKhatskevich Thanks for the patch! See 2 comments below. On 15/06/2018 15:47, AKhatskevich wrote: > Routes in `M.route_map` can be preserved during reconfigure process. > This is necessary to prevent a dramatic performance degradation just > after reconfugure and reload. 1. Problems with alignment. 2. Typo. > > Closes #117 > --- > test/router/router.result | 42 ++++++++++++++++++++++++++++++++++++++++++ > test/router/router.test.lua | 24 ++++++++++++++++++++++++ > vshard/router/init.lua | 7 +++++-- > 3 files changed, 71 insertions(+), 2 deletions(-) >