From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2C19A4765E0 for ; Wed, 30 Dec 2020 12:42:53 +0300 (MSK) From: Sergey Ostanevich Message-Id: <1A5AA266-11A6-4320-B55C-BA8486A52B95@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_D41CDA61-DBF6-429E-8DC1-ABA587412914" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Wed, 30 Dec 2020 12:42:51 +0300 In-Reply-To: <20201230085218.GO14702@root> References: <20201230084946.GV5396@tarantool.org> <20201230085218.GO14702@root> Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] misc: fix build with disabled memory profiler List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org --Apple-Mail=_D41CDA61-DBF6-429E-8DC1-ABA587412914 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii LGTM. Sergos > On 30 Dec 2020, at 11:52, Sergey Kaplun wrote: > > Hi, Igor! > > Thanks for the review! > > On 30.12.20, Igor Munkin wrote: >> Sergey, >> >> Thanks for the patch! LGTM with a single nit below. >> >> On 30.12.20, Sergey Kaplun wrote: >>> This patch fixes the regression introduced in scope of >>> b4e6bf0d82100049d29af1aa3196e781270f39d1 ('misc: add Lua API for memory >>> profiler'). Build is failed with disabled memory profiler because >> >> Typo: s/is failed/fails/. > > Fixed. Branch is force-pushed. > >> >>> related error messages are not defined. >>> >>> This patch fixes build by making LJ_ERR_PROF_MISUSE visible and avoiding >>> usage of other profiler-related errors when the profiler is disabled. >>> >>> Follows up tarantool/tarantool#5442 >>> --- >>> src/lib_misc.c | 4 ++++ >>> src/lj_errmsg.h | 2 +- >>> 2 files changed, 5 insertions(+), 1 deletion(-) >>> >> >> >> >>> -- >>> 2.28.0 >>> >> >> -- >> Best regards, >> IM > > -- > Best regards, > Sergey Kaplun --Apple-Mail=_D41CDA61-DBF6-429E-8DC1-ABA587412914 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii LGTM.

Sergos

On 30 Dec 2020, at 11:52, = Sergey Kaplun <skaplun@tarantool.org> wrote:

Hi, = Igor!

Thanks for = the review!

On 30.12.20, = Igor Munkin wrote:
Sergey,

Thanks for the patch! LGTM with a single nit below.

On 30.12.20, Sergey Kaplun wrote:
This patch fixes the = regression introduced in scope of
b4e6bf0d82100049d29af1aa3196e781270f39d1 ('misc: add Lua API = for memory
profiler'). Build is failed with disabled = memory profiler because

Typo: = s/is failed/fails/.

Fixed. Branch is force-pushed.


related error messages are not defined.

This patch fixes build by making = LJ_ERR_PROF_MISUSE visible and avoiding
usage of other = profiler-related errors when the profiler is disabled.

Follows up tarantool/tarantool#5442
---
src/lib_misc.c  | 4 ++++
src/lj_errmsg.h | = 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)


<snipped>

-- 
2.28.0


-- 
Best = regards,
IM

-- 
Best = regards,
Sergey = Kaplun

= --Apple-Mail=_D41CDA61-DBF6-429E-8DC1-ABA587412914--